Make Java implementation more idiomatic#110
Closed
ghubstan wants to merge 362 commits intoeclipse-biscuit:masterfrom
ghubstan:master
Closed
Make Java implementation more idiomatic#110ghubstan wants to merge 362 commits intoeclipse-biscuit:masterfrom ghubstan:master
ghubstan wants to merge 362 commits intoeclipse-biscuit:masterfrom
ghubstan:master
Conversation
-- Below class level field declarations -- Above method declarations
Adjust all affected classes.
-- Class level fields go above constructors -- Instance methods go below contructors -- Static members should never be prefixed (reference) via 'this' -- Merge duplicated switch statement branches into one -- Use less verbose method references with implicit args when possible -- Use static imports to reduce verbose lines when possible (very subjective)
Adjust all affected class.
Adjust affected classes.
Adjust affected classes.
This change affects many files, but only varlable and parameter names have been changed. From the perspective of a Biscuit newbie, the ambiguity is confusing.
Make Java implementation more idiomatic
Author
|
Closing due to expected file conflicts after merging #108 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am interested in using Biscuit in my Java project, and I went through the entire Biscuit Java implementation to make it more comfortable to the eyes of experienced Java developers.
There are many aspects of this project that attract me, and all the work I have done in this PR is evidence of the respect I have for the authors' work. But as it is now, I think many Java devs might be shying away from the existing Java implementation when they see all the
snake_casemethod and variable names. To them, the existing implementation is not idiomatic to the Java language. So I fixed (most) of that in this PR. (TODO: protobuf enums should be all caps.)A new release based on this PR would break existing systems using the current Java implementation, but migration would be mostly changing Biscuit API method names from
snake_casetocamelCase.I did do some refactoring too:
SymbolTable symbolTable, instead ofSymbolTable symbols).If you are interested in looking at this PR, I suggest inspecting the commits in order of oldest to newest -- you will quickly see the pattern of changes I made in each class.
Thanks,
Stan