Repository navigation
feat(updater): run every updater stage as one job per cask - #50
Merged
Merged
Conversation
Job timeouts no longer grow with the number of casks: check, publish, verify and push each run one job per cask, on that cask's UPDATE_MINUTES, so adding a cask never touches the workflow. A failing cask shows as its own red job and stops nothing else. - push legs run one at a time (max-parallel: 1), each from a fresh clone of main, so every push stays a plain fast-forward. - published lists the succeeded "publish (TOKEN)" jobs of this attempt; publish stays without uses: lines (d8.md Verification), so it can't upload a marker artifact. verified lists the checked- artifacts, so a failed verify doesn't also turn its push red. - publish and push take one token; the loop stages, their per-cask deadlines and DeadlineTests go. WorkflowTests pins the job names, matrices, timeouts and the serial push. Signed-off-by: edbfi <326875205+edbfi@users.noreply.github.com>
There was a problem hiding this comment.
ℹ️ No critical issues — one nitpick inline.
Reviewed changes: the full PR (single commit) across the workflow, scripts/update.sh, the fake gh and the updater tests.
- Per-cask jobs in
update-casks.yml:check,publish,verifyandpushuseinclude: fromJSON(...matrix),fail-fast: false, explicitname: <stage> (TOKEN)andtimeout-minutes: ${{ matrix.minutes }};pushaddsmax-parallel: 1. The privileged jobs keep their branch guard and still run main's scripts. - Collector jobs:
publishedreads succeededpublish (TOKEN)jobs from the jobs API (a failing API call aborts underset -erather than reporting[]).verifiedlistschecked-artifacts. scripts/update.sh: the loop stages,timeoutwrappers, deadlines and*-onevariants are gone;publish TOKENandpush TOKENcallfirst_attempt.stage_listednow takes a pattern and a lister function.- Tests and docs:
DeadlineTestsbecomesWorkflowTests, the fakeghgains a jobs endpoint, and the README documentsUPDATE_MINUTES.
I traced the job if conditions and needs chain for the no-update, partial-failure and all-failed cases and found them consistent. The empty-discovery case is covered by discover.sh dying when nothing matches.
Nitpicks
tests/test_updater.py:19— the fake curl's"stall"branch is now dead: its only user,test_a_stalled_cask_times_out_and_the_rest_publish, was removed along with thetimeoutwrappers. Drop the branch (and itsimport time) so the fixture doesn't advertise a behavior nothing exercises.
claude-sonnet-5-5 | 𝕏
Signed-off-by: edbfi <326875205+edbfi@users.noreply.github.com>
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changed
PR 2 of 2, following #49. Every stage of
update-casks.ymlnow runs one job per cask with that cask's own timeout. Six casks no longer fills the updater, and adding a cask never touches the workflow.timeout-minutes: ${{ matrix.minutes }}, which is the cask'sUPDATE_MINUTES(default 20; no cask sets it).checkandverifydrop from 30 to 20 minutes. The longest updater job in the last 40 runs took 45 s.fail-fast: false), so a broken cask shows up as its own red job, e.g.publish (flixor), and the others carry on.max-parallel: 1, so each push starts from a fresh clone of amainthat already has the previous cask's commit, and every push is a plain fast-forward.push's existing three-try loop still covers an owner push landing mid-run. It's still one commit and one deploy-key push per cask, as today.publishedlists the casks whosepublish (TOKEN)job succeeded in this attempt, read from the jobs API. A marker artifact would have been more robust, but d8.md's Verification requirespublishto have nouses:lines.WorkflowTestspins the job name, so a rename fails CI rather than going silent.verifiedlistschecked-artifacts, so a failedverifydoesn't also turn that cask'spushred.update-casksconcurrency group, the no-update run (plan→[], everything after it skipped), and the refusal of re-runs.publishandpushnow take one token. The loop stages,PUBLISH_DEADLINE/PUSH_DEADLINE, thetimeoutwrappers andDeadlineTestsare gone. feat(updater): add per-cask publish and push stages with their own budgets #49'spublish-one/push-onefold into them.UPDATE_MINUTES.Evidence
prek run --all-files --hook-stage manual: every hook passes (actionlint, zizmor, privileged-jobs, shellcheck, tooling tests).python3 -m unittest discover -s testsand-s scripts/tests: OK (27 and 28 tests, on Python 3.14).WorkflowTestsfails if the publish job is renamed ormax-parallel: 1is removed (both mutations tried).publishedfails rather than reporting[]when the jobs API errors.Plan after merge
check (…)for each cask,plan→[], everything after it skipped.updater-probe,updater-probe-b) updating in one run, so twopublishjobs run in parallel and twopushjobs land one after the other, both logged asbypass. A second dispatch should do nothing. Then a deliberately failing probe to show that it fails on its own. Then a teardown PR.Owner actions
None.