fix: The 'q' command quits...#292
Closed
Gyanano wants to merge 2 commits into
Closed
Conversation
- Removes the broken NotImplementedError from pick-ball mode so the documented q command no longer exits the program Closes #291 Assisted-by: OpenAI Codex
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Previously only the NotImplementedError was removed, but find_closest_ball()
can return None when no balls are eligible (all pocketed or not in can_cue).
This would crash when trying to call .get_node('pos') on None, or when the
'done' action fires with no ball selected.
Changes:
- Guard ball highlight setup with
- Wrap the 'done' handler's ball selection logic in the same None check
- Mode change to aim still happens on 'done' even if no ball was selected
Closes #291
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hkey)Fixes #291