Skip to content

fix: The 'q' command quits... #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Gyanano wants to merge 2 commits into from
Closed

fix: The 'q' command quits... #292

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34b2a8f
## Summary
invalid-email-address May 13, 2026
9d7ed40
fix(pick_ball): guard against None closest_ball in pick_ball_task
invalid-email-address May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions pooltool/ani/modes/pick_ball.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ def exit(self):
tasks.remove("pick_ball_task")

def pick_ball_task(self, task):
raise NotImplementedError("Woops, this is in a broken state, don't press that")

if not self.keymap[Action.pick_ball]:
Global.mode_mgr.change_mode(Mode.aim)
return task.done
Expand All @@ -55,19 +53,21 @@ def pick_ball_task(self, task):
if closest != self.closest_ball:
self.remove_ball_highlight()
self.closest_ball = closest
self.ball_highlight = self.closest_ball.get_node("pos")
self.add_ball_highlight()
if self.closest_ball is not None:
self.ball_highlight = self.closest_ball.get_node("pos")
self.add_ball_highlight()

if self.keymap["done"]:
self.remove_ball_highlight()
ball_id = self.closest_ball._ball.id
if ball_id is not None:
multisystem.active.cue.cue_ball_id = ball_id
visual.cue.init_focus(visual.balls[ball_id])
Global.game.log.add_msg(
f"Now cueing the {multisystem.active.cue.cue_ball_id} ball",
sentiment="neutral",
)
if self.closest_ball is not None:
self.remove_ball_highlight()
ball_id = self.closest_ball._ball.id
if ball_id is not None:
multisystem.active.cue.cue_ball_id = ball_id
visual.cue.init_focus(visual.balls[ball_id])
Global.game.log.add_msg(
f"Now cueing the {multisystem.active.cue.cue_ball_id} ball",
sentiment="neutral",
)
Global.mode_mgr.change_mode(Mode.aim)
return task.done

Expand Down