Reduce the scope of the legacy gcp secrets by fr4nc1sc0-r4m0n · Pull Request #10734 · elastic/elastic-agent

fr4nc1sc0-r4m0n · 2025-10-23T10:16:07Z

What does this PR do?

This PR aims to reduce the scope of the legacy kv/ci-shared/observability-ingest/cloud/gcp secret only for the integration-test-matrix pipeline.
This is part of the global process about removing this secret usage.

Why is it important?

It allows us to simplify the pre-command script and to limit the usage of a legacy secret which will be removed in the future.

Checklist

I have read and understood the pull request guidelines of this project.
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in ./changelog/fragments using the changelog tool
I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

This is part of: https://github.com/elastic/observability-robots/issues/2800

Questions to ask yourself

How are we going to support this in production?
How are we going to measure its adoption?
How are we going to debug this?
What are the metrics I should take care of?
...

…t-matrix

mergify · 2025-10-23T10:16:47Z

This pull request does not have a backport label. Could you fix it @fr4nc1sc0-r4m0n? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
backport-active-all is the label that automatically backports to all active branches.
backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

…mplexity

fr4nc1sc0-r4m0n · 2025-10-28T08:20:22Z

Some tests are failing but they do not appear to be related with this change

elasticmachine · 2025-10-28T12:01:16Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 1a3bd72

Failed CI Steps

x86_64:sudo: default

History

💔 Build #29467 failed 822f89e
💔 Build #29436 failed f9578a3
💛 Build #29313 was flaky 9a5b5d9
💛 Build #29240 was flaky 2607890
💔 Build #29188 failed 6536db8
💔 Build #29152 failed 3df2b36

cc @fr4nc1sc0-r4m0n

…0734

github-actions · 2025-10-29T17:34:58Z

@Mergifyio backport 8.19 9.1 9.2

mergify · 2025-10-29T17:35:07Z

backport 8.19 9.1 9.2

✅ Backports have been created

Details

#10903 [8.19] (backport #10734) Reduce the scope of the legacy gcp secrets has been created for branch 8.19
#10904 [9.1] (backport #10734) Reduce the scope of the legacy gcp secrets has been created for branch 9.1
#10905 [9.2] (backport #10734) Reduce the scope of the legacy gcp secrets has been created for branch 9.2

* Reduce the scope of the legacy secrets usage only for integration-test-matrix * Fix pipeline slug * Add google oidc plugin in integration tests ech step * Remove gcp auth plugin usage and fix pre exit command * Fix typo * Preserve ESS Credentials logic * Use parameter expansion instead of adding more logic to reduce the complexity (cherry picked from commit 41dd43d)

v1v · 2025-10-29T17:35:43Z

@fr4nc1sc0-r4m0n , forgot to mention that anytime we touch any CI related things, we need to backport to all the active branches - that's the default behaviour.

For such I added the backport-active-all label,

In some cases we need to be a bit picky and only backport to some branches, btut default it's always to all the active branches

* Reduce the scope of the legacy secrets usage only for integration-test-matrix * Fix pipeline slug * Add google oidc plugin in integration tests ech step * Remove gcp auth plugin usage and fix pre exit command * Fix typo * Preserve ESS Credentials logic * Use parameter expansion instead of adding more logic to reduce the complexity (cherry picked from commit 41dd43d)

* Reduce the scope of the legacy secrets usage only for integration-test-matrix * Fix pipeline slug * Add google oidc plugin in integration tests ech step * Remove gcp auth plugin usage and fix pre exit command * Fix typo * Preserve ESS Credentials logic * Use parameter expansion instead of adding more logic to reduce the complexity (cherry picked from commit 41dd43d) Co-authored-by: Francisco Ramon <francisco.ramon@elastic.co>

…10906)

…10906) (cherry picked from commit 0a1cf18) # Conflicts: # .buildkite/hooks/pre-command # .buildkite/pipeline.yml

…10906) (cherry picked from commit 0a1cf18) # Conflicts: # .buildkite/pipeline.yml

…10906) (cherry picked from commit 0a1cf18)

* Reduce the scope of the legacy secrets usage only for integration-test-matrix * Fix pipeline slug * Add google oidc plugin in integration tests ech step * Remove gcp auth plugin usage and fix pre exit command * Fix typo * Preserve ESS Credentials logic * Use parameter expansion instead of adding more logic to reduce the complexity (cherry picked from commit 41dd43d) Co-authored-by: Francisco Ramon <francisco.ramon@elastic.co>

… after merging #10734 (#10920)

…10906) (#10921)

…g after merging #10734 (#10919)

* Reduce the scope of the legacy secrets usage only for integration-test-matrix * Fix pipeline slug * Add google oidc plugin in integration tests ech step * Remove gcp auth plugin usage and fix pre exit command * Fix typo * Preserve ESS Credentials logic * Use parameter expansion instead of adding more logic to reduce the complexity

…0734 (elastic#10906)

Reduce the scope of the legacy secrets usage only for integration-tes…

5ab6292

…t-matrix

fr4nc1sc0-r4m0n self-assigned this Oct 23, 2025

fr4nc1sc0-r4m0n requested review from a team as code owners October 23, 2025 10:16

fr4nc1sc0-r4m0n added the Deprecation label Oct 23, 2025

fr4nc1sc0-r4m0n requested review from pkoutsovasilis and swiatekm October 23, 2025 10:16

v1v reviewed Oct 23, 2025

View reviewed changes

Comment thread .buildkite/hooks/pre-command Outdated

fr4nc1sc0-r4m0n added 2 commits October 23, 2025 13:05

Fix pipeline slug

fdd923a

Merge branch 'main' into chore/reduce-legacy-secrets-scope

3df2b36

pierrehilbert added the skip-changelog label Oct 23, 2025

pierrehilbert previously approved these changes Oct 23, 2025

View reviewed changes

Add google oidc plugin in integration tests ech step

ecb3c82

fr4nc1sc0-r4m0n dismissed pierrehilbert’s stale review via ecb3c82 October 23, 2025 14:27

fr4nc1sc0-r4m0n added 2 commits October 23, 2025 16:27

Merge branch 'main' into chore/reduce-legacy-secrets-scope

a3f7aaf

Remove gcp auth plugin usage and fix pre exit command

6536db8

v1v reviewed Oct 23, 2025

View reviewed changes

Comment thread .buildkite/hooks/pre-command

v1v reviewed Oct 23, 2025

View reviewed changes

Comment thread .buildkite/hooks/pre-exit Outdated

fr4nc1sc0-r4m0n added 6 commits October 23, 2025 19:18

Fix typo

1622f16

Preserve ESS Credentials logic

488b419

Use parameter expansion instead of adding more logic to reduce the co…

4f6147b

…mplexity

Merge branch 'main' into chore/reduce-legacy-secrets-scope

2607890

Merge branch 'main' into chore/reduce-legacy-secrets-scope

9a5b5d9

Merge branch 'main' into chore/reduce-legacy-secrets-scope

f9578a3

v1v approved these changes Oct 27, 2025

View reviewed changes

Merge branch 'main' into chore/reduce-legacy-secrets-scope

822f89e

fr4nc1sc0-r4m0n added 2 commits October 28, 2025 09:20

Merge branch 'main' into chore/reduce-legacy-secrets-scope

1eb7ace

Merge branch 'main' into chore/reduce-legacy-secrets-scope

1a3bd72

fr4nc1sc0-r4m0n merged commit 41dd43d into elastic:main Oct 28, 2025
21 checks passed

v1v added a commit to v1v/elastic-agent that referenced this pull request Oct 29, 2025

fix(bk): serverless-beats-tests start failing after merging elastic#1…

47ff7e6

…0734

v1v added a commit to v1v/elastic-agent that referenced this pull request Oct 29, 2025

fix(bk): serverless-beats-tests start failing after merging elastic#1…

3f98c48

…0734

v1v added the backport-active-all Automated backport with mergify to all the active branches label Oct 29, 2025

mergify Bot mentioned this pull request Oct 29, 2025

[8.19] (backport #10734) Reduce the scope of the legacy gcp secrets #10903

Merged

8 tasks

This was referenced Oct 29, 2025

[9.1] (backport #10734) Reduce the scope of the legacy gcp secrets #10904

Merged

[9.2] (backport #10734) Reduce the scope of the legacy gcp secrets #10905

Merged

ebeahan mentioned this pull request Oct 29, 2025

fix(bk): serverless-beats-tests start failing after merging #10734 #10906

Merged

8 tasks

v1v added a commit that referenced this pull request Oct 30, 2025

fix(bk): serverless-beats-tests start failing after merging #10734 (#…

0a1cf18

…10906)

mergify Bot pushed a commit that referenced this pull request Oct 30, 2025

fix(bk): serverless-beats-tests start failing after merging #10734 (#…

087390b

…10906) (cherry picked from commit 0a1cf18) # Conflicts: # .buildkite/hooks/pre-command # .buildkite/pipeline.yml

mergify Bot pushed a commit that referenced this pull request Oct 30, 2025

fix(bk): serverless-beats-tests start failing after merging #10734 (#…

9ef66ec

…10906) (cherry picked from commit 0a1cf18) # Conflicts: # .buildkite/pipeline.yml

mergify Bot pushed a commit that referenced this pull request Oct 30, 2025

fix(bk): serverless-beats-tests start failing after merging #10734 (#…

a6b1f51

…10906) (cherry picked from commit 0a1cf18)

v1v pushed a commit that referenced this pull request Oct 30, 2025

[9.1] (backport #10906) fix(bk): serverless-beats-tests start failing…

c6667ea

… after merging #10734 (#10920)

v1v pushed a commit that referenced this pull request Oct 30, 2025

fix(bk): serverless-beats-tests start failing after merging #10734 (#…

59e6509

…10906) (#10921)

v1v pushed a commit that referenced this pull request Oct 30, 2025

[8.19] (backport #10906) fix(bk): serverless-beats-tests start failin…

b561361

…g after merging #10734 (#10919)

hayotbisonai pushed a commit to hayotbisonai/elastic-agent that referenced this pull request Nov 23, 2025

fix(bk): serverless-beats-tests start failing after merging elastic#1…

620ab13

…0734 (elastic#10906)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reduce the scope of the legacy gcp secrets#10734

Reduce the scope of the legacy gcp secrets#10734
fr4nc1sc0-r4m0n merged 15 commits into
elastic:mainfrom
fr4nc1sc0-r4m0n:chore/reduce-legacy-secrets-scope

fr4nc1sc0-r4m0n commented Oct 23, 2025 •

edited

Loading

Uh oh!

mergify Bot commented Oct 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fr4nc1sc0-r4m0n commented Oct 28, 2025

Uh oh!

elasticmachine commented Oct 28, 2025

Uh oh!

Uh oh!

github-actions Bot commented Oct 29, 2025

Uh oh!

mergify Bot commented Oct 29, 2025 •

edited

Loading

Uh oh!

v1v commented Oct 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

fr4nc1sc0-r4m0n commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Why is it important?

Checklist

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

Uh oh!

mergify Bot commented Oct 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fr4nc1sc0-r4m0n commented Oct 28, 2025

Uh oh!

elasticmachine commented Oct 28, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

History

Uh oh!

Uh oh!

github-actions Bot commented Oct 29, 2025

Uh oh!

mergify Bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

v1v commented Oct 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fr4nc1sc0-r4m0n commented Oct 23, 2025 •

edited

Loading

mergify Bot commented Oct 29, 2025 •

edited

Loading