Don't crash when inspecting OTP 29 native records#15278
Merged
josevalim merged 2 commits intoApr 16, 2026
Conversation
wojtekmach
commented
Apr 15, 2026
| end | ||
|
|
||
| def inspect(native_record, _opts) do | ||
| :io_lib.format("~p", [native_record]) |> IO.iodata_to_binary() |
Member
Author
There was a problem hiding this comment.
this is obviously very naive implementation just to prevent crashes, a more robust one would use :record.get_module/1, :record.get_name/1, :record.get_field_names/1, :record.get/2, and maybe the new guard :erlang.is_record/2 like here:
https://github.com/erlang/otp/blob/OTP-29.0-rc3/lib/stdlib/src/io_lib.erl#L727:L750
sabiwara
approved these changes
Apr 15, 2026
| Inspect.Map.inspect_as_struct(struct, Macro.inspect_atom(:literal, module), info, opts) | ||
| end | ||
|
|
||
| def inspect(native_record, _opts) do |
Contributor
There was a problem hiding this comment.
Maybe we could add a comment that this is only temporary code, that we'll need to revisit if we add proper support for native record?
josevalim
reviewed
Apr 16, 2026
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.