Skip to content

Don't crash when inspecting OTP 29 native records #15278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 2 commits into from
Apr 16, 2026
Merged

Don't crash when inspecting OTP 29 native records #15278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
695d17c
Don't crash when inspecting OTP 29 native records
wojtekmach Apr 15, 2026
2eb6599
Apply suggestion from @josevalim
josevalim Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/elixir/lib/inspect.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,6 +669,11 @@ defimpl Inspect, for: Any do
Inspect.Map.inspect_as_struct(struct, Macro.inspect_atom(:literal, module), info, opts)
end

# A temporary clause to deal with native records until they are officially supported
def inspect(native_record, _opts) do
Copy link
Copy Markdown
Contributor

@sabiwara sabiwara Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could add a comment that this is only temporary code, that we'll need to revisit if we add proper support for native record?

Comment thread
josevalim marked this conversation as resolved.
:io_lib.format("~p", [native_record]) |> IO.iodata_to_binary()
Copy link
Copy Markdown
Member Author

@wojtekmach wojtekmach Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is obviously very naive implementation just to prevent crashes, a more robust one would use :record.get_module/1, :record.get_name/1, :record.get_field_names/1, :record.get/2, and maybe the new guard :erlang.is_record/2 like here:

https://github.com/erlang/otp/blob/OTP-29.0-rc3/lib/stdlib/src/io_lib.erl#L727:L750

end

def inspect_as_struct(map, name, infos, opts) do
open = color_doc("#" <> name <> "<", :map, opts)
sep = color_doc(",", :map, opts)
Expand Down
30 changes: 30 additions & 0 deletions lib/elixir/test/elixir/inspect_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,36 @@ defmodule Inspect.TupleTest do
end
end

defmodule Inspect.NativeRecordTest do
use ExUnit.Case, async: true

@moduletag skip: System.otp_release() < "29"

@tag :tmp_dir
test "basic", %{tmp_dir: tmp_dir} do
File.write!("#{tmp_dir}/native_records_test.erl", """
-module(native_records_test).
-export([test/0]).
-record #point{ x = 0.0, y = 0.0 }.

test() ->
#point{}.
""")

{"", 0} = System.cmd("erlc", ["native_records_test.erl"], cd: tmp_dir, stderr_to_stdout: true)

{:module, _} =
:code.load_binary(
:native_records_test,
~c"nofile",
File.read!("#{tmp_dir}/native_records_test.beam")
)

assert inspect(apply(:native_records_test, :test, [])) ==
"#native_records_test:point{x = 0.0,y = 0.0}"
end
end

defmodule Inspect.ListTest do
use ExUnit.Case, async: true

Expand Down
Loading