Repository navigation
fix(dpdk): clarify intentional RX notification result discard - #14
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC with fortified libc warns about the intentionally ignored
read()result in the RX notification drain even when it is cast tovoid. Bind the result to a[[maybe_unused]]local so this best-effort operation compiles cleanly.Keep the output-only eventfd counter uninitialized and document why:
read()writes it, and packet readiness comes from the RX queues independently of its value. A failed drain retains the existing retry-on-wake behavior.Validation on Linux ARM64:
src/io/dpdk_backend.cppwith GCC 13 and Clang 18, using the configured DPDK/SPDK headers,_FORTIFY_SOURCE=3,-Werror, and-fsyntax-only; both passed without warnings.pre-commit run --files src/io/dpdk_backend.cppandgit diff --checkpassed.No hardware DPDK runtime test was run. Architecture documentation is unchanged because notification ownership, lifetimes, and failure behavior are unchanged.