Skip to content

fix(dpdk): clarify intentional RX notification result discard - #14

Merged
thweetkomputer merged 1 commit into
mainfrom
fix/dpdk-notification-warning
Oct 13, 2026
Merged

thweetkomputer merged 1 commit into
mainfrom
fix/dpdk-notification-warning

Conversation

@thweetkomputer

Copy link
Copy Markdown
Contributor

GCC with fortified libc warns about the intentionally ignored read() result in the RX notification drain even when it is cast to void. Bind the result to a [[maybe_unused]] local so this best-effort operation compiles cleanly.

Keep the output-only eventfd counter uninitialized and document why: read() writes it, and packet readiness comes from the RX queues independently of its value. A failed drain retains the existing retry-on-wake behavior.

Validation on Linux ARM64:

  • Compiled src/io/dpdk_backend.cpp with GCC 13 and Clang 18, using the configured DPDK/SPDK headers, _FORTIFY_SOURCE=3, -Werror, and -fsyntax-only; both passed without warnings.
  • Compared GCC optimized assembly before and after; instructions are identical (only the input filename directive differs).
  • pre-commit run --files src/io/dpdk_backend.cpp and git diff --check passed.

No hardware DPDK runtime test was run. Architecture documentation is unchanged because notification ownership, lifetimes, and failure behavior are unchanged.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 806f9737-66ed-41a4-a7e8-b576b40a7ead
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thweetkomputer
thweetkomputer merged commit 8caaf75 into main Oct 13, 2026
10 checks passed
@thweetkomputer
thweetkomputer deleted the fix/dpdk-notification-warning branch October 13, 2026 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant