Skip to content

fix(dpdk): clarify intentional RX notification result discard #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thweetkomputer merged 1 commit into from
Oct 13, 2026
Merged

fix(dpdk): clarify intentional RX notification result discard #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/io/dpdk_backend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,12 @@ class DpdkBackend::Impl {
// records must be consumed by the PMD's interrupt-disable callback.
// Only ordinary hardware eventfds accept a uint64_t acknowledgement.
if (!fabric.tap && !fabric.mlx5) {
// Output-only counter: read writes it, and RX queues supply packet
// readiness independently of its value. No initialization is needed.
std::uint64_t value;
(void)::read(fd, &value, sizeof(value));
// Best-effort drain; an unacknowledged counter causes another wake.
[[maybe_unused]] const auto acknowledged =
::read(fd, &value, sizeof(value));
}
}
} notification;
Expand Down