[breaking] Update to Ember CLI 5.12.0#81
Merged
chriskrycho merged 4 commits intoemberjs:masterfrom Dec 22, 2024
Merged
Conversation
Using ember-cli-update to update dependencies and blueprints to the latest LTS CLI release.
Small changes in the prettier config in the default bluerpint. Applied here.
This is no longer recommended and is a linting violation. Removed them.
As this is the entire point of this code
Contributor
Author
|
@chriskrycho - first step to unlock #80 |
Contributor
|
Seems reasonable; I think that makes this Breaking, right? |
Contributor
Author
|
Yup, I think so. I put that in the PR title, but can't l label. |
chriskrycho
approved these changes
Dec 22, 2024
Contributor
chriskrycho
left a comment
chriskrycho
left a comment
There was a problem hiding this comment.
👍🏼 Excellent! I’ll add the label and merge it!
jelhan
reviewed
Feb 21, 2025
| "ember-source": "^3.8 || >= 4.0.0", | ||
| "@glint/template": "^1.0.2" | ||
| "@glint/template": "^1.0.2", | ||
| "ember-source": ">= 4.0.0" |
There was a problem hiding this comment.
This adds support for Ember v6. Would be great if we could release it.
If you don't want to do another major yet, we could backport that small change of the supported ember-source peer dependency. But it would be great if we could make this addon compatible with Ember v6.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated using ember-cli-update do update all blueprints and dependencies.
This is breaking:
Technically this just drops tests for these older things. I left in the
macroCondition(dependencySatisfies('ember-source'for earlier ember versions as I don't think these have to go away today.The linting config has changes that I applied as well.