Conversation
aklkv
force-pushed
the
feat/modernize
branch
2 times, most recently
from
819b4d9 to
5eadd85
Compare
aklkv
force-pushed
the
feat/modernize
branch
from
5eadd85 to
4b52b63
Compare
|
This drops testing of Ember < 5.8 |
|
aye, that's the default in the blueprint: https://github.com/ember-cli/ember-addon-blueprint/blob/main/files/.try.mjs#L29 this is def still a breaking change tho, as there was no ember-auto-import requirement before, and at least ember-auto-import will be required now |
Yes, I am noting it for later use in the CHANGELOG |
|
|
||
| </details> | ||
|
|
||
| #### DOM setup on insert → custom modifier |
| #### `didUpdate` | ||
| </details> | ||
|
|
||
| #### Reacting to argument changes → custom modifier |
| #### `willDestroy` | ||
| </details> | ||
|
|
||
| #### Cleanup on teardown → modifier destructor |
aklkv
force-pushed
the
feat/modernize
branch
from
c42023e to
78a5c8d
Compare
|
@NullVoxPopuli @kategengler any chance we can land this? |
Co-authored-by: Katie Gengler <katie@kmg.io>
Co-authored-by: Katie Gengler <katie@kmg.io>
kategengler
left a comment
kategengler
left a comment
There was a problem hiding this comment.
I'm 👍 except for those eslint changes I proposed.
Generally, though, I think it is silly that we are converting barely touched addons to the v2 format before it is default for anybody generating an addon because it means we will have to expend effort to convert this addon again to the final format.
|
the v1 addon format is actively harmful for new projects tho I dunno if it's the exact same, but it seems the fact that so many people want v2 addons kinda show that we're potentially repeating the mistake we made with holding out on embroider for so long |
|
I agree, v2 addons needed to be the default a long time ago. |
|
Noticed No CI ran here, I just re-enabled the workflow, could you kick it so it runs? |
|
closing and re-open will re-start ci as well |
3 participants
No description provided.