-
-
Notifications
You must be signed in to change notification settings - Fork 33
feat: modernize #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aklkv
wants to merge
7
commits into
emberjs:master
Choose a base branch
from
aklkv:feat/modernize
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: modernize #89
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4b52b63
feat: modernize
aklkv 0a4bd84
partially address feedback
aklkv 7ef4676
address the rest of the feedback
aklkv 8625274
add more alternative examples
aklkv 78a5c8d
make did -insert alternative example a bit more useful
aklkv f70cd6d
Update eslint.config.mjs
aklkv 842744e
Update eslint.config.mjs
aklkv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # This file is committed to git and should not contain any secrets. | ||
| # | ||
| # Vite recommends using .env.local or .env.[mode].local if you need to manage secrets | ||
| # SEE: https://vite.dev/guide/env-and-mode.html#env-files for more information. | ||
|
|
||
|
|
||
| # Default NODE_ENV with vite build --mode=test is production | ||
| NODE_ENV=development |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # Because this library needs to be built, | ||
| # we can't easily point package.json files at the git repo for easy cross-repo testing. | ||
| # | ||
| # This workflow brings back that capability by placing the compiled assets on a "dist" branch | ||
| # (configurable via the "branch" option below) | ||
| name: Push dist | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| - master | ||
|
|
||
| jobs: | ||
| push-dist: | ||
| name: Push dist | ||
| permissions: | ||
| contents: write | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 10 | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: pnpm/action-setup@v4 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version-file: package.json | ||
| cache: pnpm | ||
| - name: Install Dependencies | ||
| run: pnpm install --frozen-lockfile | ||
| - uses: kategengler/put-built-npm-package-contents-on-branch@v2.0.0 | ||
| with: | ||
| branch: dist | ||
| token: ${{ secrets.GITHUB_TOKEN }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,17 @@ | ||
| # compiled output | ||
| /dist/ | ||
| /declarations/ | ||
| dist/ | ||
| dist-tests/ | ||
| declarations/ | ||
|
|
||
| # dependencies | ||
| /node_modules/ | ||
| # from scenarios | ||
| tmp/ | ||
| config/optional-features.json | ||
| ember-cli-build.cjs | ||
|
|
||
| # misc | ||
| /.env* | ||
| /.pnp* | ||
| /.eslintcache | ||
| /coverage/ | ||
| /npm-debug.log* | ||
| /testem.log | ||
| /yarn-error.log | ||
| # npm/pnpm/yarn pack output | ||
| *.tgz | ||
|
|
||
| # ember-try | ||
| /.node_modules.ember-try/ | ||
| /npm-shrinkwrap.json.ember-try | ||
| /package.json.ember-try | ||
| /package-lock.json.ember-try | ||
| /yarn.lock.ember-try | ||
|
|
||
| # broccoli-debug | ||
| /DEBUG/ | ||
| # deps & caches | ||
| node_modules/ | ||
| .eslintcache | ||
| .prettiercache |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| export default { | ||
| plugins: ['prettier-plugin-ember-template-tag'], | ||
| overrides: [ | ||
| { | ||
| files: '*.{js,gjs,ts,gts,mjs,mts,cjs,cts}', | ||
| options: { | ||
| singleQuote: true, | ||
| templateSingleQuote: false, | ||
| }, | ||
| }, | ||
| ], | ||
| }; |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.