Array creation takes a distribution object#359
Closed
bgrant wants to merge 11 commits into
Closed
Conversation
instead of shape/dist/grid_shape
Contributor
|
This makes creating distarrays painfully verbose. Couldn't we keep the more convenient way by doing a type check on what is passed to the array creation routines? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the client-side array-creation methods to take a
Distributionobject instead of theshape,dist,grid_shapearguments directly. A user can create aDistributionobject many ways, including with those arguments. This allows all array-creation routines to create all of our supported distribution types.It is a little verbose at the moment, but we may add a more convenient "make up a distribution for me" API in the future.