Repository navigation
fix(dynamic): correct ruleset PUT envelope — { dynamicGroupRuleSet: [ruleset] } - #80
Merged
Merged
Conversation
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #78: the live rehearsal showed the array-only envelope ALSO fails — CT 3.134.1's validator, combined across both live errors, decodes the true shape: root must be an OBJECT and its
dynamicGroupRuleSetproperty must be a single-element ARRAY.putRulesetBody(the single shared writer from #78) now returns{ dynamicGroupRuleSet: [ruleset] }; all pinned assertions updated (unit, synthetic apply, portable-refs e2e; the #36 gated test flows through the same helper). Full suite 533 pass / 5 skip; typecheck + lint clean. Reopens the acceptance of #77 with the corrected shape. Refs #77.