Conversation
3 tasks
Richard87
force-pushed
the
refactor-job-status
branch
from
85fa402 to
cc69ce7
Compare
Richard87
force-pushed
the
refactor-job-status
branch
from
9a72ed2 to
6af39ec
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors how pipeline execution outcomes are represented by moving “pipeline runner result” data into RadixJob.Status.PipelineRunStatus, removing the prior ConfigMap-based result handoff.
Changes:
- Adds
pipelineRunStatustoRadixJobStatusand removes the legacyRadixJobResulttypes. - Updates pipeline-runner to write job result/build flags directly to the RadixJob status subresource during execution.
- Updates operator-side job condition derivation to read from
Status.PipelineRunStatus.Result(instead of a result ConfigMap) when the Kubernetes Job succeeds.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/apis/radix/v1/zz_generated.deepcopy.go | Updates generated deepcopy logic for the new RadixJobPipelineRunStatus pointer field. |
| pkg/apis/radix/v1/radixjobtypes.go | Introduces PipelineRunStatus in the RadixJob status schema and removes old result types. |
| pkg/apis/job/kubejob.go | Removes ConfigMap result parsing and derives final condition from PipelineRunStatus.Result (only on success currently). |
| pkg/apis/job/job.go | Updates the caller to use the renamed condition finder. |
| pipeline-runner/main.go | Removes result ConfigMap creation/teardown logic; runner now only executes and exits. |
| pipeline-runner/internal/runner/app.go | Adds status updates to RadixJob during pipeline execution, and removes ConfigMap result creation. |
| charts/radix-operator/templates/radixjob.yaml | Extends the CRD schema to include status.pipelineRunStatus. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| type RadixJobPipelineRunStatus struct { | ||
| UsedBuildKit bool `json:"usedBuildKit"` | ||
| UsedBuildCache bool `json:"usedBuildCache"` | ||
| Result RadixJobCondition `json:"status"` |
There was a problem hiding this comment.
In RadixJobPipelineRunStatus, the Go field is named Result but is serialized as JSON status. Since this is a new API surface, it’s likely clearer to align the field name with the JSON name (e.g., Status or Condition) or align the JSON tag with the field name, to reduce confusion for readers and API consumers.
Suggested change
| Result RadixJobCondition `json:"status"` | |
| Status RadixJobCondition `json:"status"` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid guesswork by operator and radix-api, the pipeline runner should own most of the RadixJob.Status field and update it as it progresses.