Generalized plot size from K32 to any size of K #803
Conversation
altendky
left a comment
altendky
left a comment
There was a problem hiding this comment.
Thanks a lot for this, plotman has been needing it for quite awhile. Could you add a changelog entry for this please? Take your pick whether you want to consider it a fix or a feature addition.
| def compute_priority(phase: job.Phase, gb_free: float, n_plots: int) -> int: | ||
| # All these values are designed around dst buffer dirs of about | ||
| # ~2TB size and containing k32 plots. TODO: Generalize, and | ||
| # ~2TB size and containing k plots. TODO: Generalize, and |
There was a problem hiding this comment.
I suspect this is still a valid reference to k32.
| # ~2TB size and containing k plots. TODO: Generalize, and | |
| # ~2TB size and containing k32 plots. TODO: Generalize, and |
| [ 2 ] ] ) | ||
|
|
||
| def test_list_k32_plots(fs: pyfakefs.fake_filesystem.FakeFilesystem) -> None: | ||
| def test_list_k_plots(fs: pyfakefs.fake_filesystem.FakeFilesystem) -> None: |
There was a problem hiding this comment.
Could you add test files for another size or two?
| def test_list_k_plots(fs: pyfakefs.fake_filesystem.FakeFilesystem) -> None: | |
| def test_list_plots(fs: pyfakefs.fake_filesystem.FakeFilesystem) -> None: |
|
|
||
| def list_k32_plots(d: str) -> typing.List[str]: | ||
| 'List completed k32 plots in a directory (not recursive)' | ||
| def list_k_plots(d: str) -> typing.List[str]: |
There was a problem hiding this comment.
| def list_k_plots(d: str) -> typing.List[str]: | |
| def list_plots(d: str) -> typing.List[str]: |
|
Suggested changes submitted in grupoxch#1. |
|
Alrighty, since I can't edit this even to update it, I'll just merge #814 which includes all your commits from here. It just won't show the clearest record of your contribution here in the PRs. Sorry about that. |
|
Oh, and thanks again for your contribution here. |
2 participants
Generalized plot size from K32 to any size of K
plotman interactivereports correct number of plots (not only k32)plotman archivecan find and archive plots of any size