Suggested changes for #803 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved tmp_overrides into scheduling: to better reflect that they change the scheduling behaviour. Added more override options to allow different tmpdir characteristics to be catered for.
Changes for reading the tmpdir overrides
…figuration options with description and examples
removed raise Exception as no longer testing
Ad missing }
Correcting a stupid mistake
…l_ from tmpdir variables
Co-authored-by: Kyle Altendorf <sda@fstab.net>
Co-authored-by: Kyle Altendorf <sda@fstab.net>
Co-authored-by: Kyle Altendorf <sda@fstab.net>
Co-authored-by: Kyle Altendorf <sda@fstab.net>
Co-authored-by: Kyle Altendorf <sda@fstab.net>
Author
|
Bah, lots of noise from other changes. If you first catch up your |
Agree to commit suggestion Co-authored-by: Kyle Altendorf <sda@fstab.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some suggested changes for ericaltendorf#803. If you prefer I can just handle this in the other repository, but I prefer to merge the PR that contributors created instead of my own separate one. Let me know how you want to proceed, but I am interested in getting your change merged. Thanks again for your contribution.