common/concurrent, db/snapshotsync: drop three review leftovers from #23812 - #23822
Merged
Conversation
…23812 Post-merge review cuts on the FrozenBlocks/CachedValue code merged in #23812, no behavior change. - FrozenBlocksObserved waits with time.After instead of NewTimer plus a deferred Stop: since go 1.23 an unreferenced timer is collected on its own, and the one-shot select form is what kvcache and kv_mdbx already use. - The publish docstring claimed that closing done before clearing running keeps a waiter from starting a pass of its own. Both writes happen under c.mu and claim takes the same mutex, so no caller can observe that order. - run returns bare, the named results are already assigned on the line above.
lupin012
marked this pull request as ready for review
September 6, 2026 13:27
lupin012
requested review from
AskAlexSharov,
sudeepdino008 and
yperbasis
as code owners
September 6, 2026 13:27
AskAlexSharov
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-merge review cuts on the
FrozenBlocks/CachedValuecode merged in #23812. No behavior change, net -5 lines.RemoteBlockReader.FrozenBlocksObservedwaits withtime.Afterinstead ofNewTimerplus a deferredStop. Since go 1.23 an unreferenced timer is collected on its own, and the one-shotselectform is whatdb/kv/kvcache/cache.goanddb/kv/mdbx/kv_mdbx.goalready use.publishdocstring claimed that closingdonebefore clearingrunningkeeps a waiter from starting a pass of its own. Both writes happen underc.muandclaimtakes the same mutex, so no caller can observe that order. The sentence is gone; the first one stays.runreturns bare: the named results are already assigned on the line above.No test added, per the trivial-change carve-out in the TDD guidelines: cosmetic only, no new logic. Existing
common/concurrenttests andmake lintare green.