common/concurrent, db/snapshotsync: drop three review leftovers from #23812

common/concurrent/cached_value.go

@@ -123,12 +123,10 @@ func (c *CachedValue[T]) run(r *run[T], produce func() (T, bool, error)) (value
 	}()
 
 	value, store, err = produce()
-	return value, err
+	return
 }
 
-// publish records the attempt, stores what is worth keeping, and ends the pass. Closing
-// done before clearing running keeps a caller from starting a pass of its own while this
-// one is still published as in flight.
+// publish records the attempt, stores what is worth keeping, and ends the pass.
 func (c *CachedValue[T]) publish(r *run[T], value T, store bool, err error) {
 	c.mu.Lock()
 	defer c.mu.Unlock()

db/snapshotsync/freezeblocks/block_reader.go

@@ -172,11 +172,9 @@ func (r *RemoteBlockReader) FrozenBlocksObserved() (uint64, bool) {
 	if observed {
 		return value, true
 	}
-	timeout := time.NewTimer(r.frozenBlocksTimeout)
-	defer timeout.Stop()
 	select {
 	case <-refreshed:
-	case <-timeout.C:
+	case <-time.After(r.frozenBlocksTimeout):
 	}
 	value, observed, _ = r.frozenBlocks.Load()
 	return value, observed