Skip to content

⚡ Replace O(N^2) dictionary deep equality check with O(N) lookup #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esenmx merged 1 commit into from
Jul 1, 2026
Merged

⚡ Replace O(N^2) dictionary deep equality check with O(N) lookup #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions darwin/mapkit_flutter/Sources/mapkit_flutter/messages.g.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,18 +121,13 @@ enum messagesPigeonInternal {
case (let lhsDictionary, let rhsDictionary) as ([AnyHashable: Any?], [AnyHashable: Any?]):
guard lhsDictionary.count == rhsDictionary.count else { return false }
for (lhsKey, lhsValue) in lhsDictionary {
var found = false
for (rhsKey, rhsValue) in rhsDictionary {
if deepEquals(lhsKey, rhsKey) {
if deepEquals(lhsValue, rhsValue) {
found = true
break
} else {
return false
}
if let rhsValue = rhsDictionary[lhsKey] {
if !deepEquals(lhsValue, rhsValue) {
return false
}
} else {
return false
}
if !found { return false }
}
return true

Expand Down
Loading