Repository navigation
Open
3 / 103 of 10 issues completedDescription
Tracks work that should or could follow the cutover to upstream go-ethereum (#20266). None of it blocks the cutover.
New items go here as sub-issues, or in the list below while they are too small for an issue.
Small items
- Unexport
Genesis.GethGenesis(). After op-devstack: remove the in-process op-geth L2 EL and the EL-kind selector #24156 its only caller outside tests isop-core/genesis/block.go, in its own package. (done in op-service,op-core,op-chain-ops!: delete helpers without callers #24309) - Delete the
acceptance-testsandacceptance-tests-runrecipes inrust/kona/tests/justfileand their README section. They change into anoptimismcheckout belowrust/kona/teststhat no longer exists, so they cannot run. - Add a test that fails when sysgo configures its op-nodes for the wrong engine kind. The restart tests pass with either value of
SupportsPostFinalizationELSync(op-devstack: sysgo hard-codes SupportsPostFinalizationELSync=false while running op-reth #23318, op-devstack: configure sysgo op-nodes for an op-reth engine #24163). - Delete the helpers that the cutover (go.mod!: build against upstream go-ethereum v1.17.10 #24176) leaves without a caller:
eth.BlockAsPayloadEnv,eth.DecodeTransactionsandgenesis.GetBlockFromTag;eth.BlockAsPayloadkeeps only a test caller. Check optimism-premium for uses first. (done in op-service,op-core,op-chain-ops!: delete helpers without callers #24309) - Make
FromGethReceiptreject deposit receipts. A go-ethereum receipt cannot carry the deposit nonce and receipt version, so wrapping one that an upstream client decoded from an L2 block and hashing it gives a wrong receipts root. (done in op-core!: reject deposit receipts in FromGethReceipt #24308) - Optional: delete
GethChainConfig(), so thatop-core/paramsno longer needs go-ethereum's chain config type. Its two remaining callers would own what they take from go-ethereum: the JSON codec declares the Ethereum fork fields itself, andGenesis.ToBlock()computes the state root and builds the header from the op-core fork predicates. The golden vectors pin both outputs. - Bump go-ethereum to the first release that contains rpc: treat a null error in a response as no error ethereum/go-ethereum#36151. Until then every Go service fails its calls to a JSON-RPC endpoint that adds
"error": nullto successful responses (go.mod!: build against upstream go-ethereum v1.17.10 #24176 lists this as a breaking change). - Clean up
docs/ai/opgeth-decoupling.mdso that it only holds what matters now and later. The cutover (go.mod!: build against upstream go-ethereum v1.17.10 #24176) rewrites it from a migration plan into a description of the monorepo on upstream go-ethereum. Still to do after it: read it once more for statements that only explain the migration, drop the comparisons with op-geth that no reader needs, remove the downstream-repos section once those repos have moved, and give the file and its entry inCLAUDE.mda name that does not say "decoupling". - Revisit op-node's hidden
--l2.skip-sync-start-checkflag. Its doc comment recommends it for--syncmode=execution-layertogether with--syncmode=snapon op-geth, and its usage text names the oldl2.engine-syncflag. op-reth has no snap sync: the pinned reth has a snap/2 (EIP-8189) library crate that no node wires in, and snap/2 needs block access lists, which an OP Stack chain does not have yet. Decide whether the flag still has a use with op-reth's execution-layer sync, then reword or remove it. - Bump optimism-premium to a monorepo commit after the cutover, which drops the op-geth
replaceof its Go module (optimism-premium#506).
🤖 Co-created with Claude Fable 5.2
Metadata
Metadata
Assignees
Labels
No labels
Activity
update-gethskill for go-ethereum version bumps #24278