Skip to content

kona/tests/proofs: audit Karst and Lagoon coverage now that the harness runs on op-reth-test-engine #24171

Open

Description

@sebastianst

The kona proof action tests ran on an in-process op-geth L2 engine until #21905. A Karst or Lagoon behaviour that op-geth does not implement could not get a proof test. The harness now runs on op-reth-test-engine, so that limit is gone.

Task

  1. List the consensus changes of Karst and Lagoon from the specs, for derivation and for payload execution.
  2. Map each to a proof test in rust/kona/tests/proofs.
  3. Add a test for each behaviour that has none. Every new test needs a case that fails without the behaviour, e.g. a junk claim or a batch that must be dropped.

Coverage today

Candidates to check first

  • Karst maps to Osaka: the Osaka EVM changes on L2, and the payload versions op-node selects from Karst on.
  • A batch with user transactions in the Karst or Lagoon activation block is dropped.
  • Lagoon activates Sequencer-Defined Metering: a batch that carries a PostExec transaction is rejected before Lagoon and accepted from it (IsSDM). No proof test mentions PostExec transactions.
  • Add Lagoon to the default fork matrix, so the existing tests run at Lagoon too.

🤖 Co-created with Claude Fable 5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions