Repository navigation
docs: treat storage-root and trie-persistence changes as OP consensus - #23120
Merged
Merged
Conversation
Since Isthmus the header's withdrawals root is a per-account storage root, which upstream only uses for RPC. Add it to the preconditions OP breaks and to the consensus-critical risk list, so reth bump reviews check changes to storage-root providers and to trie persistence (partial persistence, state masking) under the default engine settings. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
joshklop
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reth bump review guide treated trie persistence and provider storage-root reads as non-consensus, because upstream only uses them for RPC. For OP they are consensus: the Isthmus
withdrawalsRootis a storage root that op-reth computes throughStorageRootProvider::storage_root. The review of #23046 found that reth v2.6.0's state masking made that root wrong, and every upstream state-root test still passed.This adds the case to the guide as an upstream precondition OP breaks and as a consensus-critical risk item. It also says how to test for it: engage persistence and masking, which neither upstream end-to-end tests nor short tests under default settings do. It is a docs-only change with no effect on users. The companion issue for a differential test is #23119.
🤖 Co-created with Claude Opus 5.5