Skip to content

docs: treat storage-root and trie-persistence changes as OP consensus - #23120

Merged
sebastianst merged 1 commit into
developfrom
seb/reth-review-persistence-layout
Oct 1, 2026
Merged

sebastianst merged 1 commit into
developfrom
seb/reth-review-persistence-layout

Conversation

@sebastianst

Copy link
Copy Markdown
Member

The reth bump review guide treated trie persistence and provider storage-root reads as non-consensus, because upstream only uses them for RPC. For OP they are consensus: the Isthmus withdrawalsRoot is a storage root that op-reth computes through StorageRootProvider::storage_root. The review of #23046 found that reth v2.6.0's state masking made that root wrong, and every upstream state-root test still passed.

This adds the case to the guide as an upstream precondition OP breaks and as a consensus-critical risk item. It also says how to test for it: engage persistence and masking, which neither upstream end-to-end tests nor short tests under default settings do. It is a docs-only change with no effect on users. The companion issue for a differential test is #23119.

🤖 Co-created with Claude Opus 5.5

Since Isthmus the header's withdrawals root is a per-account storage
root, which upstream only uses for RPC. Add it to the preconditions OP
breaks and to the consensus-critical risk list, so reth bump reviews
check changes to storage-root providers and to trie persistence (partial
persistence, state masking) under the default engine settings.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@sebastianst
sebastianst added this pull request to the merge queue Oct 1, 2026
Merged via the queue into develop with commit 47d22f7 Oct 1, 2026
49 checks passed
@sebastianst
sebastianst deleted the seb/reth-review-persistence-layout branch October 1, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants