Repository navigation
op-acceptance-tests,op-devstack,op-service: cover eth version negotiation and transaction propagation between op-reth and op-geth - #23443
Conversation
0b4f897 to
56e7d65
Compare
|
This pr has been automatically marked as stale and will be closed in 5 days if no updates |
2a9b08c to
c7e6250
Compare
56e7d65 to
e63e2d9
Compare
c7e6250 to
a3c78e4
Compare
e63e2d9 to
3c2a8a0
Compare
|
Claude: Detail moved out of the PR description when the branch was squashed into 3c2a8a0. It is the description as it stood before the squash, unedited, so it describes the earlier commits. Nothing checked how op-reth and op-geth peer and exchange transactions: What the tests coverAll three tests run on a
What the burst can and cannot show: the number of hashes announced exceeds what op-reth tracks per peer after the bump, but op-reth fetches while the burst is still arriving, and whether its unfetched set from op-geth ever reached 4096 (the point where it drops further announcements) is not observable through RPC. The test therefore proves that op-reth takes a cap-sized announcement burst from an untrusted op-geth peer in its stride, not that the drop path ran. Proving the latter needs reth's Each sender has exactly one transaction, so a hash the fetcher drops cannot leave a nonce gap behind; the accounts are funded through a tree of distributors ( Matrix: direction {op-reth to op-geth, op-geth to op-reth} as subtests (the dialing side is the sender, so both dial directions are covered too); CL {op-node, kona-node} through Local verificationDebug op-reth built from this stack's Rust tree (identical to
Against #23046's op-reth (reth 2.6.0, built from the bump head 93d9ec9, op-node): all five cells pass, 71s. Negotiated versions, as the verification criterion asks: op-geth v1.101702.4-rc.1 advertises Burst: op-reth's pool held 4107 to 4112 of the 4112 at the first poll after the batches were accepted, on Unit: Observations
Seams
Stacked on #23440, #23438, #23436, #23431, #23427, #23421 and #23418. Closes #23402 |
a3c78e4 to
6cabe52
Compare
3c2a8a0 to
6c242fd
Compare
6cabe52 to
eb73ef7
Compare
65ef2e0 to
88cb7c3
Compare
eb73ef7 to
574c473
Compare
88cb7c3 to
a4dc3ae
Compare
4b951df to
a6fb532
Compare
a4dc3ae to
8dc8ff7
Compare
a6fb532 to
c4f5482
Compare
8dc8ff7 to
d13cbfd
Compare
|
🤖 Fable says: A note from the op-geth decoupling work (#20257). The new op-geth is EOL as of Karst, and #21744 removes the in-process op-geth L2 EL from op-devstack/sysgo ( For this PR that leaves two options: keep the eth-version and propagation coverage between op-reth nodes only, or, if op-reth↔op-geth peering still needs a test for pre-Karst networks, run op-geth as an external pinned binary rather than the in-process sysgo EL. The second is new harness work, so it would be good to settle whether that coverage is still wanted before this leaves draft. |
…tion and transaction propagation between op-reth and op-geth Add an acceptance test package that peers an op-reth and an op-geth follower as basic peers, requires them to negotiate the highest eth version both advertise, requires a transaction submitted to either to reach the other's pool and a block, and hands op-geth twice as many transactions to announce as op-reth tracks per peer, sent so that op-reth is offered more than its cap, requiring op-reth to keep the session, keep syncing, include at least a cap's worth of the burst, and, once mined transactions have left its pool, account for every burst transaction it pooled as included or still pooled. Both nodes run pool limits well above the burst, the funding leaves room for the L1 data fee, the pair is used only once the sender has caught up with the sequencer, and the op-geth follower runs a genesis without Karst, which op-geth v1.101702.4-rc.2 refuses. The devstack gains basic (untrusted) EL peering, typed admin_peers lookups including handshaking peers, batch transaction submission, logged pool waits including waits for pending, pooled and included transactions and for transactions to leave the pool, offline signing, and op-geth options on the mixed preset; txplan gains a static chain ID option, and an explicit fee cap is no longer recomputed when the tip cap is pinned after it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
c4f5482 to
9ac60ed
Compare
d13cbfd to
5f79226
Compare
Nothing checked how op-reth and op-geth peer and exchange transactions, and reth 2.6 changes the default eth version, the transaction fetcher and peer reputation handling.
op_reth_opgeth_peeringpeers an op-reth and an op-geth follower as untrusted peers and requires the highest common eth version, transaction propagation both ways, and that op-reth, offered more transaction hashes than its per-peer cap, keeps the session, includes at least a cap's worth of the burst and accounts for every burst transaction it pooled. Adds basic EL peering, typedadmin_peers, batch submission and pool waits to the devstack.Stacked on #23440. Closes #23402. Local verification, findings and notes: detail comment.
Breakdown
AI Reviews
<ISODATETIME><COMMITID>Fable 5.1 xhigh<ISODATETIME><COMMITID>GPT-6.1-Sol xhigh<ISODATETIME><COMMITID>Opus 5.5 xhigh🤖 Generated with Claude Code