Repository navigation
Conversation
Sequences a real refunded Lagoon block and checks debug_traceTransaction, debug_traceCall at an index and trace_replayTransaction against the receipt and the committed balances. Fails on develop: traces report pre-refund gas. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
OpEthApi overrides Trace::replay_block_until, Trace::inspect_transaction_in_block and Call::spawn_replay_transaction to replay through the block executor, which applies the SDM settlement keyed by each transaction's position. Fixes debug_traceTransaction, trace_replayTransaction / trace_transaction / trace_get, ots_traceTransaction / ots_getTransactionError, and debug_traceCall / debug_traceCallMany / eth_callMany at a transaction index. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Superseded by #23670, which combines the per-transaction and block-level overrides on ethereum-optimism/reth#26. Tracked in ethereum-optimism/protocol-team#485. Closing as superseded; branch kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 1 of the plan in ethereum-optimism/protocol-team#485: fix the per-transaction RPC replay paths in op-reth alone, with no reth change.
On SDM blocks the RPC paths that replay a block's transactions run them on a bare EVM, so they report pre-refund gas and unsettled balances; only the block executor applies the settlement.
OpEthApinow overridesTrace::replay_block_until,Trace::inspect_transaction_in_blockandCall::spawn_replay_transactionto replay through the executor. That fixesdebug_traceTransaction,trace_replayTransaction/trace_transaction/trace_get,ots_traceTransaction/ots_getTransactionError, anddebug_traceCall/debug_traceCallMany/eth_callManyat a transaction index. The BAL argument these methods take is ignored: op-reth never caches a block access list.Block-level paths (
debug_traceBlock*,debug_intermediateRoots,traceChain, andtrace_block/trace_replayBlockTransactions/trace_filter) are hard-coded loops in reth and still report pre-refund results. They need the reth extension points in ethereum-optimism/reth#25 and follow in a stacked PR.debug_trace_post_exec.rssequences a real refunded Lagoon block (moved from #23465) and checks the paths above against the receipt and the committed balances. It fails ondevelop(debug_traceTransactiongas 53006, receipt 53005) and passes here; the op-rethitsuite passes and clippy is clean.🤖 Generated with Claude Code