Repository navigation
Conversation
The 12 go-tests nodes shared one build-cache key per revision. Cache keys are immutable, so only the first node to finish saved; the other nodes' new compiles were discarded and rebuilt on the next push. Each node now restores and saves its own cache. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 6, 2026
3 of 5 tasks
Contributor
Agent approval checkHead branch claude/go-tests-per-node-build-cache matches agent prefix claude/ Current head: A write-capable human can approve by submitting a native review or by commenting:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each of the 12
go-testsnodes now keeps its own Go build cache, so a node stops rebuilding the packages a PR changed on every push. This is a draft until its net effect is measured.The problem. The 12 nodes share one build-cache key per revision. Cache keys are immutable, so only the first node to finish saves. In develop job 5800161, node 10 uploaded 2.6 GiB and the other eleven skipped, which discarded their new compiles.
What changes. The cache namespace includes the node index. One file, five added lines.
Effect. CI only: the
go-testsjob's cache restore and save steps.Expected cost and benefit, not yet measured here. On #23151's pipeline, per-node caches restored 0.3–0.6 GiB in 3–8 s, against 2.6 GiB in 17–25 s per node today. The costs:
Testing. All 115 CI checks pass on this PR. That shows the change is correct, not that it is faster: the first pipeline only populates the new keys. Before marking this ready, compare
go-testsduration and save sizes on a second pipeline against develop.Context. This is one of four small PRs that change code CircleCI runs, found while reviewing the RWX pilot (#23151): #23772, #23775, #23776 and #23780. Each stands alone. The additive RWX shadow is #23783. This change was split out of #23775 after
ci-config-reviewerflagged the missing numbers; it found no correctness problems.Tracked in #24044.
🤖 Generated with Claude Code