Repository navigation
kona-client: fail Cannon runs when the client exits non-zero - #23772
Merged
Merged
Conversation
`cannon run` exits 0 whatever the program's exit code is, and the client rejects an invalid claim by exiting non-zero. So kona-host-client-offline, a required-rust-ci job, passed even when the client failed inside Cannon. Both Cannon recipes now write the final state explicitly and fail unless `cannon witness` reports that the client exited with code 0. The offline recipe also stops at the first failing command, like the other recipes, so a failed run cannot be checked against a stale final state. The witness download now retries transient failures, as other CI fetches do, and drops an etag that has no tar beside it, which would otherwise produce a 304 with nothing to extract. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
teddyknox
marked this pull request as ready for review
October 29, 2026 16:26
teddyknox
added a commit
that referenced
this pull request
Nov 9, 2026
A hosted RWX run of pr-gates.yml at 1b4923d failed in three tasks. - cannon-offline: Cannon writes rust/kona/out.bin.gz, and git does not ignore that file (#23772 adds the ignore line). The Rust target cache commit saw it as a source change. The wrapper now moves the final state into its report, and the cache error names the changed files. - contracts-gate-receipt: the five heavy-fuzz-modified verdicts were skipped because the commit changes no contract test files, and the receipt counts a skip as a failure. Circle's job halts with success on an empty test list. The verdicts now always run, and restore accepts an empty preparation after it proves that the selection is still empty. The unused eligible value is removed. - main-helper-tests: the l2-chains-sync live fixture wrote a forge version file by hand, but the check now runs go test (#23643). The fixture installs the forge package like the other main-check fixtures. The contract verdict's test-results path also matches the per-EVM-pass JUnit reports again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 9, 2026
einar-oplabs
approved these changes
Nov 10, 2026
einar-oplabs
previously approved these changes
Nov 10, 2026
--retry-delay 2 replaced curl's exponential backoff with a fixed 2 s wait, so the five retries gave up after about 10 s. Without it curl waits 1, 2, 4, 8 and 16 s, which outlasts longer release-CDN and redirect failures. A missing asset now fails after about 31 s instead of 10 s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
einar-oplabs
approved these changes
Nov 10, 2026
3 of 5 tasks
Contributor
Agent approval checkHead branch claude/kona-cannon-offline-exit-check matches agent prefix claude/ Current head: A write-capable human can approve by submitting a native review or by commenting:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kona-host-client-offline-cannon, a job thatrequired-rust-cidepends on, passes today even when kona-client fails inside Cannon. This PR makes it fail in that case.The problem.
cannon runexits 0 whatever the guest's exit code is (cannon/cmd/run.gologsExecution stopped exited=… code=…and returns nil). kona-client rejects an invalid claim by exiting non-zero. So the job cannot catch the regression it exists to catch.What changes.
run-client-cannonandrun-client-cannon-offline) now fail unlesscannon witnessreports that the client exited with code 0.set -o errexit -o nounset -o pipefail, like the other recipes in the file. A failedcannon runnow stops the recipe, so the new check cannot read a stale final state.docs/ai/docker.md, it leaves out--retry-delay, which would replace the backoff with a fixed wait. It also drops an etag that has no tar beside it; that etag otherwise gets a bodyless 304 and leaves nothing to extract.out.bin.gz.cannon runalready wrote this final state intorust/konaby default; the recipes now pass--outputonly to fix the path that the check reads.Effect. Only these two recipes change, in CI and in local runs. Nothing turns red today: the latest merge-queue run of the job logs
exited=true code=0.Testing. CI runs
kona-host-client-offline-cannonwith the new check. CI covers only the success path; no CI job makes the client exit non-zero.Context. This is one of four small PRs that change code CircleCI runs, found while reviewing the RWX pilot (#23151): #23772, #23775, #23776 and #23780. Each stands alone. The additive RWX shadow is #23783, which checks the exit code in its own wrapper; this PR fixes it where both local runs and CI use it. No repo review agent's trigger matches this diff (shell and justfile only).
Tracked in #24044.
🤖 Generated with Claude Code