Repository navigation
ci,op-acceptance-tests: run SafeDB op-geth resync tests in dedicated jobs - #23824
einar-oplabs wants to merge 3 commits into
Conversation
…consumers Validate SafeDB history across restart and resync, Cannon execution-step proofs through game resolution, and dispute-monitor proof consumers. Run op-geth resync coverage sequentially before normal acceptance tests for both consensus clients, and document the historical RPC contract.
…dy consumer tests The op-geth SafeDB resync step now runs after the sharded suite so a resync failure cannot skip shard 0's share of it, restricts itself to the two cases that SkipOnOpReth, and fails when any of them skips or does not pass. The cannon_kona preset relies on the runtime's default SafeDB path, the dispute-monitor classification test drops a wait on a status new games already have, and the CL-sync resync comment describes CL sync rather than EL sync. The safeHeadAtL1Block and superroot_atTimestamp docs gain the invocation table and example style used by the other methods on the page. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…jobs The two resync cases SkipOnOpReth and ran as an extra step on shard 0 of each sharded acceptance job, which shard-tests.sh cannot balance. Move the step into a safedb-resync-test justfile recipe and run it in its own single-node op-node and kona-node jobs, both required by ci-gate. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
200d261 to
269d763
Compare
|
🤖 Fable says: A note from the op-geth decoupling work (#20257). This PR adds two op-geth is EOL as of Karst, and #21744 removes the in-process op-geth L2 EL from op-devstack/sysgo ( #23827 makes the SafeDB resync tests run on op-reth in the existing acceptance jobs, which makes these jobs unnecessary. Can this be closed in favour of #23827? |
Follow-up to #23787, splitting the op-geth SafeDB resync step out of the sharded acceptance jobs as agreed in #23787 (comment).
The two resync cases SkipOnOpReth, so the sharded op-reth suite never exercises them. #23787 ran them as an extra step on shard 0 of each acceptance job, which
shard-tests.shcannot account for, so shard 0 was always longer by the full resync runtime. This moves the step into anop-acceptance-testsjustfile recipe,safedb-resync-test, and runs it in two dedicated single-node jobs,safedb-resync-opn-op-geth-fusakaandsafedb-resync-kona-op-geth-fusaka, onxlarge.gen2. Both are required byci-gate, as the shard-0 step was before. The recipe keeps the-runrestriction and the fail-on-skip guard, forcesDEVSTACK_L2EL_KIND=op-gethso it is also runnable locally, and writes the samelogs/<run>/summary.loglayout asacceptance-testso the job's result-printing steps work unchanged.Based on
einar/safedb-remaining-validation; retarget todeveloponce #23787 merges.Validation:
circleci config validate --org gh/ethereum-optimism; all 23ci-gaterequires resolve to workflow job names.just --listandjust -n safedb-resync-testrender; ShellCheck on the rendered body reports only the justfile's own backtickREPO_ROOTconstant, shared withacceptance-test.go test -listwith the recipe's run filter selects exactlyTestPreserveDatabaseOnCLResyncandTestTruncateDatabaseOnELResync.🤖 Generated with Claude Code