Repository navigation
kona-node,safedb,op-acceptance-tests: validate persistence and proof consumers - #23787
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
c80e096 to
9bdfff7
Compare
|
GPT-6 (effort unspecified): Decision: keep the SafeDB resync and normal acceptance steps sequential in #23787. The corrected concurrency experiment completed in CircleCI pipeline #138260, using commit 265daedd8b.
All six jobs passed: 201 top-level test executions, zero failures, zero skips. Every resync phase passed all three required tests with op-geth; the normal phase used op-reth and matched its complete frozen selection. Kona retained its 32 GiB runner and op-node its 40 GiB runner. There were zero OOM, OOM-kill, memory-high, or memory-max events. Kona's 8+1 run recorded 189 Parallel execution saved approximately 4–5 minutes on shard zero, but other shards already determine overall CI completion. Successful reference runs had Kona shard zero at 11m 21s versus a slowest other shard of 16m 21s, and op-node at 11m 45s versus 21m 08s. These shard-zero savings therefore do not establish a full-pipeline speedup. This was one cold-build-cache trial per configuration, including compilation, with identical source and a fixed client-specific test selection. Warm-cache savings and general stability are not established. Memory was sampled every second; brief peaks may be missed. The first experiment (#138258) is excluded because a child-shell environment reset caused two required resync tests to skip; the corrected harness prevents that reset and rejects any resync skips. We will retain sequential execution for now. Per-job summary JSON, memory CSV, and test logs are available in the corrected pipeline's artifacts. |
joshklop
left a comment
There was a problem hiding this comment.
Left a few comments, mostly on the new CircleCI op-geth SafeDB step. I checked the new docs and the kona README against the kona RPC code: field names, error codes and messages, the --safedb.path flag, and how the genesis case is handled all match.
One more thing outside the diff: in safeheaddb_clsync/safeheaddb_test.go, the comment at L47 in the function this PR touches still says the restarted CL "will use EL sync to resync the chain". The test configures sync.CLSync for both nodes and asserts the DB is preserved, so the comment looks copied from the ELSync test.
|
Fable 5.1 (effort unspecified): The CL-sync comment in |
|
Opus 5.5 (high): #23827 affects the op-geth resync step discussed in #23787 (comment):
Proposed order: land #23827, then remove the op-geth step from this PR (or a follow-up), together with the Edited: an earlier version said the op-geth step would pass with every test skipped. That was wrong; the Jovian pin and the skip guard in this PR prevent it. |
…consumers Run the SafeDB acceptance cases that skipped kona-node against both consensus clients: SafeDB history across restart and resync, Cannon execution-step proofs through game resolution with time travel, and proposer and dispute-monitor consumers of super and output roots. The two SafeDB resync cases skip on op-reth, so a shard-0 CI step runs them on op-geth, pinned to Jovian at genesis, after the sharded suite. The step fails when either case skips or does not pass. Document the kona-node SafeDB RPCs' historical availability and the SafeDB RPC error contract. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
200d261 to
269d763
Compare
… checks The op-geth resync step accepts a test's "--- PASS"/"--- SKIP" output line when test2json drops the result event, and sets no_output_timeout above go's -timeout so a hang ends in a goroutine dump. The proposer test checks the super root's output root against the node's output at that block, and that verified_required_l1 is the first SafeDB record with that block safe. The dispute-monitor agreement test checks the SafeDB record at the game's L1 head directly, since dispute-mon also agrees when SafeDB is unreadable. The invalid-root case, which never reads SafeDB, is removed. The DSL gains SuperRootQuerier.AwaitSuperRootAtTimestamp and L1ELNode.BlockRefByHash for these checks. Only the ELSync resync test pins Jovian at genesis, so the restart test on the same preset runs on the default fork. The SafeDB RPC error contract is documented only in the kona-node RPC docs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…enesis The first super-root game can commit to the L2 genesis block, whose required L1 is fixed at 0 without a SafeDB read. The proposer test waits for the first game at or after the second block's timestamp, using the new DisputeGameFactory.WaitForGameFrom. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ot checks DisputeGameFactory gains WaitForSuperGameFrom, which retries transient reads and checks the super game type; it and WaitForGame share one polling loop. SuperRootQuerier.AwaitSuperRootAtTimestamp reports the last query error on timeout, and AwaitSuperRootMatching asserts the root claim on the awaited response. L2CLNode.SafeHeadRecordAtL1Block returns nil when the SafeDB has no record, so tests need no op-node import. TestTruncateDatabaseOnELResync asserts that the SafeDB floor moves past its pre-resync value. The CL-resync test's comment states what it can observe, and its package is named safeheaddb_clsync. The op-geth EL step runs both packages in parallel with a 20m go timeout and names the CL kind in its failure messages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🤖 Fable says: A note from the op-geth decoupling work (#20257). This PR adds a CI step that runs the SafeDB resync tests with op-geth is EOL as of Karst, and #21744 removes the in-process op-geth L2 EL from op-devstack/sysgo ( #23827 makes these two tests run on op-reth through an explicit |
…nc test Wiping the EL makes the CL reset to genesis, which leaves a genesis record, so the SafeDB floor drops to 0 instead of moving past its pre-resync value on both op-node and kona-node. The floor does not show whether EL sync truncated the database. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Thanks, good call out. |
…ning-validation Resolve the SafeDB resync tests to develop's versions from #23827 (explicit EL wipe, no op-reth skips, no Jovian pins), keeping this branch's safeheaddb_clsync package name and client-neutral restart comment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Opus 5.5 (high): Done, in that order. After #23827 merged, |
joshklop
left a comment
There was a problem hiding this comment.
LGTM. All earlier comments are addressed. The op-geth resync step is now moot because #23827 runs the EL-resync tests on op-reth. I re-checked the kona SafeDB and superroot error strings in the docs against the code, and they match.
Why
kona-node's SafeDB RPCs need acceptance coverage on both consensus clients, and these cases used to skip kona-node.
What
WaitForSuperGameFrom,AwaitSuperRootMatching,SafeHeadRecordAtL1BlockandL1ELNode.BlockRefByHash.Closes #22265. Closes #22279. Advances #23473. CI on
68cf64ea2dpassed (54 passed, 6 skipped). Re-squash into one signed commit before merge.Breakdown
🤖 Generated with Claude Code