Repository navigation
op-devstack,op-acceptance-tests: run EL-resync tests on op-reth - #23827
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try the Wiz Code extension for VS Code, JetBrains, or Visual Studio. |
what are the pros and cons of opt-in vs opt-out in this context? |
Opus 5.5 (high): Opt-in means Opt-in, pros
Opt-in, cons
Opt-out, pros
Opt-out, cons
Opt-in seems right to me. The remaining risk is the forgotten |
1377dc4 to
7756dda
Compare
sebastianst
left a comment
There was a problem hiding this comment.
Approving. Wipe() is opt-in, fails loudly when called on a running node or on a backend that can't wipe, and resets exactly the reth datadir and the proofs-history dir while keeping the p2p key. So the peering and resync paths now really run on op-reth, in both CL lanes. einar's threads are addressed or declined for reasons that hold.
Two things outside this diff:
TestTruncateDatabaseOnELResyncchecks no lower bound, so it cannot tell a truncated SafeDB from a preserved one. I'm looking into what op-node actually does there and will file a follow-up if the test needs pinning.- #23787 adds
WithJovianAtGenesisto these two tests unconditionally. After this lands, that part should be dropped there, or the op-reth lanes lose Karst coverage for them.
🤖 Co-created with Claude Fable 5.2
7756dda to
d879454
Compare
cfaf3fd to
26880aa
Compare
The SafeDB resync and offset-EL-safe tests stop the verifier EL expecting that to wipe its chain, which only holds for op-geth's in-memory storage. op-reth keeps its datadir across Stop/Start, so the tests were skipped on op-reth (and, under Karst, op-geth skips them too). Add an opt-in Wipe step for L2 ELs: op-reth deletes its data dirs and re-runs init, op-geth only checks that it is stopped. The tests now wipe explicitly and run on op-reth. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- offset_el_safe: wait for the restarted EL before peering, and allow the same 90-attempt budget as TestTruncateDatabaseOnELResync for the full EL sync after the wipe. - safeheaddb_clsync: fix the comment; the verifier is in CL sync mode, so after the wipe it derives the chain again from L1 rather than EL-syncing. - op-reth: drop the separate dataDir field and recreate every entry in dataDirs, so the wipe and init cannot disagree about which directory to reset. - gap_clp2p: link the op-reth skip to #23317. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Without a lower bound, these tests pass even if Wipe leaves the chain in place. Check that the verifier EL's unsafe head is genesis right after it restarts, before its CL starts, as safedb_parity/cl_resync_test.go does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
26880aa to
b050c96
Compare
…ning-validation Resolve the SafeDB resync tests to develop's versions from #23827 (explicit EL wipe, no op-reth skips, no Jovian pins), keeping this branch's safeheaddb_clsync package name and client-neutral restart comment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
TestTruncateDatabaseOnELResync,TestPreserveDatabaseOnCLResyncandTestELSyncSafeRetractedByOffsetstop the verifier EL on the assumption that doing so wipes its chain. Only op-geth (in-memory) behaves that way. op-reth keeps its datadir across Stop/Start, so on op-reth these tests would restart an EL that still has its chain, and never exercise a resync. They were skipped on op-reth, and op-geth now skips every Karst chain, so ondevelopthey currently run in no configuration.With this PR, ELs can be wiped explicitly. The three tests now run in the normal op-reth acceptance jobs. Locally, with op-node, the wiped verifier EL-syncs from genesis and the SafeDB is reset after EL sync completes; with kona-node, the two SafeDB tests also pass. That would also make a separate op-geth invocation for these tests unnecessary (see #23787 (comment)). This PR overlaps with #23787 in the two SafeDB test files, so whichever lands second needs a small rebase.
Stop/Startsemantics are unchanged;Wipeis opt-in, so existing tests that rely on op-reth keeping its data across a restart are unaffected. The original "peering issue" skips no longer reproduce: their recorded failures match bugs fixed in #22052, #22153 and #22487.Not covered:
TestELSyncSafeRetractedByOffsetnow skips on kona-node, which rejectsOffsetELSafe(it was never reachable there before); tracked in #23828.gap_clp2palso wipes now, but stays skipped on op-reth: with the wipe it gets past its old failure and hits a different one, now recorded in the skip comment.go-code-reviewerran and its findings are applied.safedb-reviewerwas not run because no SafeDB code changes. op-geth was not exercised locally, because these chains activate Karst.🤖 Generated with Claude Code