Skip to content

op-node: keep follow-source heads when upstream CurrentL1 is not on our L1 yet - #23989

Closed
joshklop wants to merge 1 commit into
developfrom
joshklop/follow-source-current-l1-soft-fail
Closed

joshklop wants to merge 1 commit into
developfrom
joshklop/follow-source-current-l1-soft-fail

Conversation

@joshklop

@joshklop joshklop commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Light nodes (--l2.follow.source) reject a whole follow-source poll, and count it as error_l1_lookup, when their own L1 RPC doesn't have the upstream's CurrentL1 yet. On the staging devnets, the L1 endpoint is a consensus-aware proxyd whose consensus head moves back a few blocks when a lagging L1 backend rejoins. That makes this happen in bursts on every light node at once, and it fires the l2-follow-source-error-rate-* alerts. From Nov 1–8, all 1,309 follow-source errors on sepolia-devnet-2, sepolia-devnet-3 and platforms-1 were this case, and every one fell in an L1 backend lag window.

After this change, the node applies the already-verified safe and finalized heads, leaves CurrentL1 unchanged, and increments op_node_default_follow_source_current_l1_not_found_total instead of recording an error. A CurrentL1 hash mismatch or any other lookup error still rejects the poll. A matching CurrentL1 is what proves the L1 blocks holding the batches are on our chain, so those cases stay strict.

Effect on operators: follow-source error rates drop, and there is one new counter. A follower whose L1 RPC stays behind indefinitely no longer shows up in the error rate, so an alert on this counter belongs in the alert rules. That's a follow-up.

Reviews: go-code-reviewer ran. Its main suggestion, keeping mismatches and other lookup errors strict, is adopted. safedb-reviewer doesn't apply: follow mode promotes safe heads with an empty L1 source either way. The kona-node equivalent is #23990.

🤖 Generated with Claude Code

…ur L1 yet

A light node checks the upstream CurrentL1 against its own L1 RPC. When that
RPC is a few blocks behind the upstream's (for example a consensus-aware L1
proxyd whose head moves back while a lagging backend rejoins), the block is
not found and the whole poll was rejected and counted as error_l1_lookup,
discarding safe and finalized heads that were already verified.

Treat a not-found CurrentL1 like an upstream that reports none: apply the
verified heads, leave CurrentL1 unchanged, and count it in the new
follow_source_current_l1_not_found_total metric. A CurrentL1 hash mismatch or
any other lookup error still rejects the poll.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant