Repository navigation
Conversation
… on our L1 yet A kona light node checks the delegate's current_l1 against its own L1 provider. When that provider is a few blocks behind the delegate's (for example a consensus-aware L1 proxyd whose head moves back while a lagging backend rejoins), the block is not found and the whole sync status was rejected, discarding safe and finalized heads that were already verified. Treat a not-found current_l1 as a soft failure: send the verified heads to the engine, leave the published derivation origin unchanged, and count it in kona_node_derivation_delegate_current_l1_not_found_total. A current_l1 hash mismatch or any other lookup error still rejects the status. A current_l1 that is the same block as a head's L1 origin needs no second lookup and counts as verified. The actor stays generic over its L1 ChainProvider. To tell a missing block from a failed lookup, the provider's error must now implement the new L1LookupError trait, which AlloyChainProviderError implements by matching its BlockNotFound variant. TestChainProvider can now be told to fail lookups of given block numbers, so the tests cover that case too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
joshklop
force-pushed
the
joshklop/kona-delegate-current-l1-soft-fail
branch
from
November 19, 2026 23:31
372e6fb to
7153ca2
Compare
This was referenced Nov 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack, in merge order: #23990 → #23883 → #23859.
kona light nodes (derivation delegation) reject a delegate's whole sync status when their own L1 provider doesn't have the delegate's
current_l1yet. On the staging devnets, the L1 endpoint is a consensus-aware proxyd whose consensus head moves back a few blocks when a lagging L1 backend rejoins. Verified safe and finalized heads are then thrown away in bursts. This is the kona-node side of #23989, which makes the same change in op-node.After this change, the node sends the verified heads to the engine, leaves the published derivation origin unchanged, and increments
kona_node_derivation_delegate_current_l1_not_found_total. Acurrent_l1hash mismatch or any other lookup error still rejects the status. A matchingcurrent_l1is what proves the L1 blocks holding the batches are on our chain, so those cases stay strict.API change:
DelegateDerivationActordrops itsL1Providertype parameter and takesAlloyChainProviderdirectly. That's its only instantiation, and it lets the not-found case match the typedAlloyChainProviderError::BlockNotFoundrather than an opaqueChainProvider::Error. There are no users outsidekona-node-service.Reviews:
rust-code-reviewerran, and its suggestions are adopted:rstestcasesNot done:
current_l1, while op-node treats it as "not reported". That's a separate follow-up.🤖 Generated with Claude Code