Repository navigation
ci: restore the act and deny checks on op-v2.7.0 - #34
Conversation
RUSTSEC-2026-0441 marks pin-utils unmaintained with no safe upgrade. It is reachable only on wasm targets, through alloy-provider's wasmtimer.
f602b81 to
f13963a
Compare
|
Fable 5.1 (xhigh): Heads-up from a local evaluation of this branch ( Setup. Monorepo Result: no 2.7.0 regression. Every failure traced to something already known on 2.6 or to develop drift unrelated to reth (op-geth rc.2's Karst kill switch, develop's Three things for this branch before it is tagged:
Numbers, for the record: Rust 825/828 (the 3 are stack-side: a CLI prune test asserting pre-reconciliation behavior and the two known engine-model crash cases), proofs_history acceptance 4/4 ok on both CLs, e2e 52/54 (the 2 are the known |
Pin the reth crates to the head of ethereum-optimism/reth#35, which stacks on ethereum-optimism/reth#34 on top of op-v2.7.0. Both are unmerged, so the pin is a rev until op-v2.7.0-0 is tagged. Sync the shared dependencies to the versions reth v2.7.0 requires: alloy 2.5.0, alloy-hardforks 0.4.9, reth-core 0.8.1, revm 43 and revm-inspectors 0.44. Adapt to the upstream API changes: - StateProviderDatabase now takes an EvmStateProvider (paradigmxyz/reth#27109). Wrap each provider with into_evm_state_provider, on a reference where it is used again. - CancelOnDrop moved from reth-revm to reth-tasks (paradigmxyz/reth#27466). - StateProviderFactory gained a Primitives type (paradigmxyz/reth#26923). Where a bound also names NodePrimitivesProvider, the debug witness API now says which one it means. - BlockAndReceipts holds SharedReceipts (paradigmxyz/reth#27427). - The e2e setup functions folded into E2ETestSetupBuilder (paradigmxyz/reth#27432). - MemoryOverlayStateProvider was removed in favour of the overlay manager (paradigmxyz/reth#26923). The test engine records every validated block in the manager it shares with its provider, so it now appends a block to its real parent with state_with_block_appended. The flashblock pending state does the same, but on the canonical anchor: a speculative block's parent is the pending block before it, which the overlay does not know. The next commit shows that this breaks for speculative builds.
|
Thanks for the run. Here is where each of the three points ended up:
ethereum-optimism/optimism#24024 is merged and pins this stack by |
Auto-merge was disabled for another pull request in the stack
Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com> (cherry picked from commit f269bcc)
Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com> (cherry picked from commit 0fc98b4)
Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com> (cherry picked from commit e29c343)
Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com> (cherry picked from commit cdc4e09)
Co-authored-by: Matthias Seitz <19890894+mattsse@users.noreply.github.com> (cherry picked from commit 569c770)
(cherry picked from commit 7a5c817)
|
One - npx playwright install --with-deps chromium
+ npx playwright@1.64.1 install --with-deps chromiumAt the stack head 0447ceb, 🤖 Co-created with Claude Opus 5.5 |
The docs job ran an unpinned `npx playwright install`, which resolves the newest `playwright` at run time and broke while npm had 1.65.0 of the CLI but not of `playwright-core`. Pin it to 1.64.1, as op-v2.6.0 does since #38. Nothing in the docs lockfile depends on a Playwright version. (cherry picked from the book.yml half of commit 806fa3b)
Auto-merge was disabled for another pull request in the stack
What
Restores
op-v2.7.0's checks with two commits:secure-runnerunder act, so the act jobs run again, and addsscan-github-actions.ymlto the config header's list of excluded workflows.deny.toml. That advisory markspin-utilsunmaintained, with no safe upgrade. RustSec assigned the ID on 2026-11-05, after the branch was pushed, andlint-denystarted failing.Why
v2.7.0 adds
tempoxyz/gh-actions/actions/secure-runneras the first step of 43 jobs; the v2.6.0 workflows had none. It starts StepSecurity's Harden Runner and Socket's Aegis, and its pre step exchanges a GitHub OIDC token for their policy credentials. act never receives that token, so every act job onop-v2.7.0fails within seconds, before any check runs (act-lint-fmt):How
--local-repositorymaps a whole repository at a ref.tempoxyz/gh-actions@ee2960a6also serves the vendoredtaiki-e/install-action(10 uses) anddtolnay/rust-toolchain(2 uses), which the checks need, so mapping it to the no-op would break them. Instead, a new step fetches that one commit, replaces onlyactions/secure-runner/action.ymlwith the existing no-op, and act maps the repository to that copy.tempoxyz/gh-actionsat any other sha. A later replay then gets a message naming the mismatch, instead of the OIDC error above.scan-github-actions.yml, new in v2.7.0, runs on pull requests through a tempoxyz reusable workflow that needs OIDC. It was never in the act matrix; the header now records the exclusion.pin-utilsis reachable only on wasm targets, throughalloy-provider→wasmtimer:cargo tree -i pin-utils --all-featuresprints nothing for the host target.Caveats
act-e2e.ymlandact-integration.ymlnow run and fail on two tests that race on CircleCI's runners. The test code is the same in v2.7.0. test(e2e): wait for pruner in RocksDB pruning tests (#27601), harden Osaka blob conversion (#27687) #35, stacked on this PR, cherry-picks upstream's test-only fixes. Neither PR can passreth-acton its own; test(e2e): wait for pruner in RocksDB pruning tests (#27601), harden Osaka blob conversion (#27687) #35 describes the two ways to merge them.actjobs run without Harden Runner, which monitors outbound connections on GitHub runners: it audits them by default and can block them under a policy stored in tempoxyz's StepSecurity account. They also run without Aegis's package-download checks.op-v2.6.0's act jobs never had either, and both depend on tempoxyz's credential services, so enabling GitHub Actions on the fork would not restore them. Whether the fork's CircleCI jobs need network monitoring of their own is a question for cloud-security.op-v2.6.0has the samepin-utilsdependency, so itslint-denynow fails too. The ignore can be cherry-picked there if another PR targets that branch.Alternatives
disable-enforcement: trueto eachsecure-runnerstep: 43 workflow edits that would conflict on every replay, with flags that look unexplained in upstream's files.uses:lines to their originals and map all oftempoxyz/gh-actionsto the no-op. Each.vendored.jsonshows the copies are exact upstream commits, so this would run the same code. But it adds 12 conflicting edits, and any vendored action upstream adds later would silently become a no-op instead of running.