Skip to content

chore: drop pruned euler-interfaces address keys from the addresses composable - #794

Merged
Seranged merged 1 commit into
masterfrom
chore/drop-pruned-address-keys
Aug 10, 2026
Merged

Seranged merged 1 commit into
masterfrom
chore/drop-pruned-address-keys

Conversation

@kasperpawlowski

Copy link
Copy Markdown
Contributor

Summary

Prepares for euler-xyz/euler-interfaces#226 (removes the deprecated perspective/registry/eUSD address keys from EulerChains.json) and the matching SDK Deployment type cleanup (euler-xyz/euler-sdks#93).

None of the removed keys were actually read anywhere in the app — the only consumed periphery keys are termsOfUseSigner, swapVerifier and swapper, and the token consumers read only EUL/rEUL. This drops the dead pass-through fields from useEulerAddresses so the composable compiles cleanly once the SDK types are bumped:

  • eulerPeripheryAddresses: remove governedPerspective, eulerUngoverned0x/NzxPerspective, eulerEarnGovernedPerspective, externalVaultRegistry, irmRegistry, oracleAdapterRegistry (kept: escrow + EVK factory + EulerEarn factory perspectives)
  • eulerTokenAddresses: remove eUSD/seUSD (all-zero placeholders, never launched)
  • docs: Earn-vault verification is sourced from the earn-vaults.json label file, not the retired eulerEarnGovernedPerspective (the docs claim was already stale vs the code)

No runtime behavior change — removal of unused fields plus a docs correction.

Test plan

  • vitest run tests/composables/useREULLocks.test.ts: 5 passed
  • eslint on touched files: clean

…omposable

euler-interfaces is removing the deprecated perspective, registry and
eUSD address keys from EulerChains.json. None of them were read
anywhere in the app (the only consumed periphery keys are
termsOfUseSigner, swapVerifier and swapper; token consumers read only
EUL/rEUL), so this drops the dead pass-through fields ahead of the
matching SDK Deployment type cleanup.

Also corrects the vault verification docs: Earn vaults are verified
via the earn-vaults.json label file, not the (retired)
eulerEarnGovernedPerspective.
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: euler-xyz/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 04a15252-d458-42da-8c98-4822e68bfb3a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@kasperpawlowski
kasperpawlowski marked this pull request as ready for review August 10, 2026 15:00

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

No high-severity issues found. This is a dead-field cleanup in useEulerAddresses plus a docs correction: the removed periphery/token keys had zero live readers in the app, and Earn verification already comes from earn-vaults.json labels rather than eulerEarnGovernedPerspective.

Reviewed: composables/useEulerAddresses.ts, docs/vault-labels-and-verification.md, tests/composables/useREULLocks.test.ts · Traced beyond the diff: all eulerPeripheryAddresses / eulerTokenAddresses call sites (swapVerifier/swapper/termsOfUseSigner, EUL/rEUL); Earn/escrow verification paths in composables/useVaults.ts, composables/useVaultRegistry.ts, utils/vault/categories.ts, utils/vault/governor-verification.ts, server/utils/vaults-cache.ts / labels-view.ts; SDK StandardEVaultPerspectives usage (app only requests ESCROW) · Protocol skills consulted: none needed (no money-moving or protocol-semantics change)

Not flagged

  • Kept-but-unused pass-throughs (eulerEarnFactoryPerspective, evkFactoryPerspective) are intentional per the PR description and unused by app code today; escrow still resolves via the SDK deployment lookup, not this composable.
  • SDK 1.2.5 still types the pruned keys; this PR only stops re-exporting them so a later interfaces/SDK bump does not break the composable.
Open in Web View Automation 

Sent by Cursor Automation: Lite PR Reviewer

@Seranged
Seranged merged commit e0d6d4c into master Aug 10, 2026
5 checks passed
@Seranged
Seranged deleted the chore/drop-pruned-address-keys branch August 10, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants