chore: drop pruned euler-interfaces address keys from the addresses composable - #794
Conversation
…omposable euler-interfaces is removing the deprecated perspective, registry and eUSD address keys from EulerChains.json. None of them were read anywhere in the app (the only consumed periphery keys are termsOfUseSigner, swapVerifier and swapper; token consumers read only EUL/rEUL), so this drops the dead pass-through fields ahead of the matching SDK Deployment type cleanup. Also corrects the vault verification docs: Earn vaults are verified via the earn-vaults.json label file, not the (retired) eulerEarnGovernedPerspective.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: euler-xyz/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
Review summary
No high-severity issues found. This is a dead-field cleanup in useEulerAddresses plus a docs correction: the removed periphery/token keys had zero live readers in the app, and Earn verification already comes from earn-vaults.json labels rather than eulerEarnGovernedPerspective.
Reviewed: composables/useEulerAddresses.ts, docs/vault-labels-and-verification.md, tests/composables/useREULLocks.test.ts · Traced beyond the diff: all eulerPeripheryAddresses / eulerTokenAddresses call sites (swapVerifier/swapper/termsOfUseSigner, EUL/rEUL); Earn/escrow verification paths in composables/useVaults.ts, composables/useVaultRegistry.ts, utils/vault/categories.ts, utils/vault/governor-verification.ts, server/utils/vaults-cache.ts / labels-view.ts; SDK StandardEVaultPerspectives usage (app only requests ESCROW) · Protocol skills consulted: none needed (no money-moving or protocol-semantics change)
Not flagged
- Kept-but-unused pass-throughs (
eulerEarnFactoryPerspective,evkFactoryPerspective) are intentional per the PR description and unused by app code today; escrow still resolves via the SDK deployment lookup, not this composable. - SDK 1.2.5 still types the pruned keys; this PR only stops re-exporting them so a later interfaces/SDK bump does not break the composable.
Sent by Cursor Automation: Lite PR Reviewer


Summary
Prepares for euler-xyz/euler-interfaces#226 (removes the deprecated perspective/registry/eUSD address keys from
EulerChains.json) and the matching SDKDeploymenttype cleanup (euler-xyz/euler-sdks#93).None of the removed keys were actually read anywhere in the app — the only consumed periphery keys are
termsOfUseSigner,swapVerifierandswapper, and the token consumers read onlyEUL/rEUL. This drops the dead pass-through fields fromuseEulerAddressesso the composable compiles cleanly once the SDK types are bumped:eulerPeripheryAddresses: removegovernedPerspective,eulerUngoverned0x/NzxPerspective,eulerEarnGovernedPerspective,externalVaultRegistry,irmRegistry,oracleAdapterRegistry(kept: escrow + EVK factory + EulerEarn factory perspectives)eulerTokenAddresses: removeeUSD/seUSD(all-zero placeholders, never launched)earn-vaults.jsonlabel file, not the retiredeulerEarnGovernedPerspective(the docs claim was already stale vs the code)No runtime behavior change — removal of unused fields plus a docs correction.
Test plan
vitest run tests/composables/useREULLocks.test.ts: 5 passedeslinton touched files: clean