Conversation
| /** | ||
| * @var array | ||
| */ | ||
| protected $roles = ['Project Manager']; // TODO: TBC |
There was a problem hiding this comment.
Has this todo been resolved? If so, we should remove it, else we should resolve it.
| /** | ||
| * @var string | ||
| */ | ||
| protected $version = ''; |
There was a problem hiding this comment.
I think this can be dropped, see the recent commits on other jobs
| */ | ||
| protected $version = ''; | ||
|
|
||
| private $project_id; |
There was a problem hiding this comment.
Is there a reason we don't have a type hint?
| { | ||
| parent::handle(); | ||
|
|
||
| $this->query_string['limit'] = '100'; |
There was a problem hiding this comment.
I haven't really looked into all the ESI changes, but is this for the new cursor pagination thing? I wonder if we don't better push this into the esi request logic instead of having it in the job.
| /** | ||
| * @var string | ||
| */ | ||
| protected $version = ''; |
There was a problem hiding this comment.
same as above, I don't think this is required anymore
| /** | ||
| * @var string | ||
| */ | ||
| private $project_id; |
There was a problem hiding this comment.
I think we can also add a type hint
| // Weird early projects, bad data | ||
| $thresholdDate = Carbon::parse('2025-01-01'); | ||
| if ($lm->isBefore($thresholdDate)){ | ||
| logger()->warning('early project detected', ['body' => $details]); // TODO investigate |
| // Weird early projects | ||
| $thresholdDate = Carbon::parse('2025-01-01'); | ||
| if ($lm->isBefore($thresholdDate)){ | ||
| logger()->warning('early project detected', ['project' => $project]); // TODO investigate |
There was a problem hiding this comment.
TODO: What is that TODO supposed to do?
| $proj = CorporationProject::firstOrNew([ | ||
| 'id' => $project->id, | ||
| ]); | ||
| // dd($project->last_modified, gettype(Carbon($project->last_modified)->format('Y-m-d H:i:s')), Carbon($project->last_modified)->format('Y-m-d H:i:s')); |
2 participants
Corp Projects eveapi pushup.
Work TBD is adding to API