Skip to content

[build-tools] Separate Appium and simulator preview logs - #4586

Merged
gwdp merged 1 commit into
mainfrom
gwdp/serve-sim-appium-logs
Oct 15, 2026
Merged

gwdp merged 1 commit into
mainfrom
gwdp/serve-sim-appium-logs

Conversation

@gwdp

@gwdp gwdp commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Why

Keep Appium controller output and its simulator preview in separate log phases.

How

  • Keep serve-sim output in its own preview phase while the Appium controller step stays active.
  • Stream Appium output into its controller step.
  • Clean up partial startup failures and remove Appium files even when shutdown fails.

Test Plan

  • Fresh Devin review completed without findings.
  • CI passed on the current head.
  • Local Appium session started through EAS CLI, Universe API/workflow worker and the rebuilt build-tools. The website preview worked with serve-sim 0.6.3 on an iPhone 17 Simulator; an Appium client connected through ngrok and read the Settings UI. Appium output and serve-sim output were ingested under separate controller and preview phases.
Earlier and automated validation

After restacking, Codex ran 62 focused tests and built all 13 EAS packages successfully. Changed-file lint, formatting and changelog validation passed. Claude reviewed the earlier controller slices and found no correctness issues.

Earlier launch E2E covered Universe-generated steps through build-tools download/install/start to serve-sim on a real iOS Simulator, checking one app start, launch arguments and the deep link. Those runs used loopback cloud tunnel/reporting adapters and a pinned local build/device. The current local session used real ngrok tunnels. Hosted workers were not tested. On this machine, Appium's default capabilities select the first booted Simulator, so the test client explicitly selected the intended iPhone 17 UDID.

Screenshots

Separate Simulator preview logs

Appium controller logs

Authorship and LLM use

Gabe wrote the initial implementation, directed the iterations and requested the split once he was happy with the result. Codex made fixes, split the PRs and updated this description; Claude and Devin reviewed the broader work. The reviews led to redaction and shutdown refinements. Gabe reviewed the final code through #4601, including this Appium diff. Local Appium validation is described above; hosted execution remains untested.

@gwdp

gwdp commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author

Codex separated Appium and simulator-preview logging, corrected cleanup and changelog details, and restacked this layer under Gabe's direction. Gabe reviewed the final code through #4601, including this Appium diff. Current-head CI is green. Earlier local Appium/website validation and screenshots are preserved; hosted execution was not tested.

— Codex

@codecov

This comment has been minimized.

@gwdp
gwdp force-pushed the gwdp/serve-sim-appium-logs branch from b76fade to da9b12d Compare October 9, 2026 19:49
@gwdp
gwdp force-pushed the gwdp/serve-sim-appium-logs branch from da9b12d to f023c80 Compare October 9, 2026 23:23
@gwdp
gwdp added this pull request to stack #4599 October 10, 2026 00:26
@gwdp
gwdp removed this pull request from stack #4599 October 10, 2026 08:38
@gwdp
gwdp added this pull request to stack #4604 October 10, 2026 08:40
@gwdp
gwdp removed this pull request from stack #4604 October 10, 2026 16:54
@gwdp
gwdp added this pull request to stack #4606 October 10, 2026 16:55
@gwdp

This comment has been minimized.

@devin-ai-integration

This comment has been minimized.

devin-ai-integration[bot]

This comment was marked as outdated.

@gwdp
gwdp marked this pull request as ready for review October 10, 2026 18:52
@gwdp
gwdp requested a review from szdziedzic October 10, 2026 18:52
@douglowder

Copy link
Copy Markdown
Contributor

eas-cli now uses changesets for changelogs (#4580). The required "Check for a changeset" check fails on PRs that edit CHANGELOG.md.

To update this PR:

  1. Revert the changes to CHANGELOG.md.
  2. Run yarn changeset, select the changed packages and the bump type, and write the summary.
  3. Commit the new file in .changeset/.

The release adds the PR link and the author to the entry. If this PR needs no changelog entry, revert the CHANGELOG.md changes and add the "no changelog" label.

@gwdp

gwdp commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

Rebased this layer onto gwdp/serve-sim-agent-device-logs and moved its release note from CHANGELOG.md into its own changeset. Current-main behavior was preserved.

Validation: focused build-tools tests, changeset validation, changed-file lint/format and build-tools typecheck passed. No new native or hosted acceptance was run for this restack.

Published head: 18c09c0ae526fd499ab42140dea38075c44a9c7f.

— Codex

@gwdp
gwdp force-pushed the gwdp/serve-sim-appium-logs branch 2 times, most recently from 18c09c0 to 7fc9c52 Compare October 15, 2026 03:34
Base automatically changed from gwdp/serve-sim-agent-device-logs to main October 15, 2026 05:09
@gwdp
gwdp force-pushed the gwdp/serve-sim-appium-logs branch from 7fc9c52 to cff315b Compare October 15, 2026 05:09
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
@gwdp
gwdp force-pushed the gwdp/serve-sim-appium-logs branch from cff315b to f03004f Compare October 15, 2026 16:15
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding a changeset!

@gwdp
gwdp merged commit 50e1f2a into main Oct 15, 2026
10 checks passed
@gwdp
gwdp deleted the gwdp/serve-sim-appium-logs branch October 15, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants