Repository navigation
[build-tools] Separate Appium and simulator preview logs - #4586
Conversation
|
Codex separated Appium and simulator-preview logging, corrected cleanup and changelog details, and restacked this layer under Gabe's direction. Gabe reviewed the final code through #4601, including this Appium diff. Current-head CI is green. Earlier local Appium/website validation and screenshots are preserved; hosted execution was not tested. — Codex |
This comment has been minimized.
This comment has been minimized.
b76fade to
da9b12d
Compare
da9b12d to
f023c80
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
eas-cli now uses changesets for changelogs (#4580). The required "Check for a changeset" check fails on PRs that edit To update this PR:
The release adds the PR link and the author to the entry. If this PR needs no changelog entry, revert the |
|
Rebased this layer onto Validation: focused build-tools tests, changeset validation, changed-file lint/format and build-tools typecheck passed. No new native or hosted acceptance was run for this restack. Published head: — Codex |
18c09c0 to
7fc9c52
Compare
7fc9c52 to
cff315b
Compare
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
cff315b to
f03004f
Compare
|
✅ Thank you for adding a changeset! |
Why
Keep Appium controller output and its simulator preview in separate log phases.
How
Test Plan
Earlier and automated validation
After restacking, Codex ran 62 focused tests and built all 13 EAS packages successfully. Changed-file lint, formatting and changelog validation passed. Claude reviewed the earlier controller slices and found no correctness issues.
Earlier launch E2E covered Universe-generated steps through build-tools download/install/start to serve-sim on a real iOS Simulator, checking one app start, launch arguments and the deep link. Those runs used loopback cloud tunnel/reporting adapters and a pinned local build/device. The current local session used real ngrok tunnels. Hosted workers were not tested. On this machine, Appium's default capabilities select the first booted Simulator, so the test client explicitly selected the intended iPhone 17 UDID.
Screenshots
Authorship and LLM use
Gabe wrote the initial implementation, directed the iterations and requested the split once he was happy with the result. Codex made fixes, split the PRs and updated this description; Claude and Devin reviewed the broader work. The reviews led to redaction and shutdown refinements. Gabe reviewed the final code through #4601, including this Appium diff. Local Appium validation is described above; hosted execution remains untested.