Repository navigation
[eas-cli] Default simulator previews to authenticated links - #4619
Conversation
|
Codex implemented the CLI private/public preview behavior under Gabe’s direction, then added the selected warning before public links in start/get output. JSON remains unchanged. The warning follow-up passes 66 relevant CLI tests, production TypeScript compilation, and changed-source lint/format. — Codex |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6bf506f to
1fc7be9
Compare
This comment has been minimized.
This comment has been minimized.
1fc7be9 to
623cec3
Compare
This comment has been minimized.
This comment has been minimized.
0060a3b to
d9f0bad
Compare
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
|
eas-cli now uses changesets for changelogs (#4580). The required "Check for a changeset" check fails on PRs that edit To update this PR:
The release adds the PR link and the author to the entry. If this PR needs no changelog entry, revert the |
9215da3 to
11f8a34
Compare
11f8a34 to
e99db61
Compare
|
Codex restacked this PR on the rebased build-tools change. CLI executable changes are unchanged; the release note now uses the required changeset format and retains its breaking-change classification. All 188 focused CLI tests, production typecheck, full lint/format, and changeset validation pass. No review was re-requested. — Codex |
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Edited-by: Codex
e99db61 to
0c443ae
Compare
|
✅ Thank you for adding a changeset! |
Why
Create simulator sessions with authenticated preview links by default, and save explicit public sharing on the session. Part of ENG-28070.
How
/previewURL by default fromsimulator:start. Use--public-linkto create a session with public sharing.publicPreviewon start, defaulting to false.simulator:getread the saved preference for both human and JSON output; it has no--public-linkoption and does not update the preference.previewApiUrltonullin JSON for all five config types, including Android. Preserve controller credentials.This changes JSON for private sessions:
previewApiUrlis null and preview tokens are omitted.Stacked on build-tools #4620. Deploy WWW #32347 and its preceding website layers before releasing this CLI; both the
publicPreviewcreation input and session output field must be deployed.Test Plan
Codex ran all 188 focused CLI tests after rebasing, plus production typecheck and full repository lint/format. The CLI executable changes are unchanged by the rebase. Both release notes use the current changeset format and pass validation. Earlier local command-output QA used loopback cloud adapters; hosted acceptance and schema-sync against the deployed WWW field remain pending.
Gabe directed the behavior, reviewed the final changes, and selected the public-sharing warning text. Codex wrote the code, tests, generated files, and description. Opus review led to a fix for Android preview URLs in private JSON output.
— Codex