Skip to content

[eas-cli] Default simulator previews to authenticated links - #4619

Merged
gwdp merged 5 commits into
mainfrom
gwdp/eng-28070-cli-preview-links
Oct 15, 2026
Merged

gwdp merged 5 commits into
mainfrom
gwdp/eng-28070-cli-preview-links

Conversation

@gwdp

@gwdp gwdp commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Why

Create simulator sessions with authenticated preview links by default, and save explicit public sharing on the session. Part of ENG-28070.

How

  • Print the authenticated /preview URL by default from simulator:start. Use --public-link to create a session with public sharing.
  • Save publicPreview on start, defaulting to false.
  • Have simulator:get read the saved preference for both human and JSON output; it has no --public-link option and does not update the preference.
  • For private sessions, remove preview tokens and set previewApiUrl to null in JSON for all five config types, including Android. Preserve controller credentials.
  • For public sessions, include the preview API URL and its token when available. Human-readable start/get output warns about access to the app and potentially sensitive logs immediately before the public link.

This changes JSON for private sessions: previewApiUrl is null and preview tokens are omitted.

Stacked on build-tools #4620. Deploy WWW #32347 and its preceding website layers before releasing this CLI; both the publicPreview creation input and session output field must be deployed.

Test Plan

Codex ran all 188 focused CLI tests after rebasing, plus production typecheck and full repository lint/format. The CLI executable changes are unchanged by the rebase. Both release notes use the current changeset format and pass validation. Earlier local command-output QA used loopback cloud adapters; hosted acceptance and schema-sync against the deployed WWW field remain pending.

Gabe directed the behavior, reviewed the final changes, and selected the public-sharing warning text. Codex wrote the code, tests, generated files, and description. Opus review led to a fix for Android preview URLs in private JSON output.

— Codex

@linear-code

linear-code Bot commented Oct 14, 2026

Copy link
Copy Markdown

ENG-28070

@gwdp

gwdp commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author

Codex implemented the CLI private/public preview behavior under Gabe’s direction, then added the selected warning before public links in start/get output. JSON remains unchanged. The warning follow-up passes 66 relevant CLI tests, production TypeScript compilation, and changed-source lint/format.

— Codex

@codecov

This comment has been minimized.

@gwdp gwdp self-assigned this Oct 14, 2026
@gwdp

This comment has been minimized.

@gwdp
gwdp force-pushed the gwdp/eng-28070-cli-preview-links branch from 6bf506f to 1fc7be9 Compare October 14, 2026 03:42
@gwdp
gwdp changed the base branch from main to gwdp/eng-28070-worker-preview-sharing October 14, 2026 03:42
@gwdp
gwdp added this pull request to stack #4621 October 14, 2026 03:42
@gwdp

This comment has been minimized.

@gwdp

This comment has been minimized.

@gwdp
gwdp force-pushed the gwdp/eng-28070-cli-preview-links branch 2 times, most recently from 0060a3b to d9f0bad Compare October 14, 2026 06:58
@gwdp
gwdp marked this pull request as ready for review October 14, 2026 08:15
@gwdp
gwdp requested a review from szdziedzic October 14, 2026 08:15
@github-actions

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
packages/eas-cli/** @douglowder
packages/eas-cli/src/build/** @sjchmiela

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment thread packages/eas-cli/src/simulator/utils.ts
@douglowder

Copy link
Copy Markdown
Contributor

eas-cli now uses changesets for changelogs (#4580). The required "Check for a changeset" check fails on PRs that edit CHANGELOG.md.

To update this PR:

  1. Revert the changes to CHANGELOG.md.
  2. Run yarn changeset, select the changed packages and the bump type, and write the summary.
  3. Commit the new file in .changeset/.

The release adds the PR link and the author to the entry. If this PR needs no changelog entry, revert the CHANGELOG.md changes and add the "no changelog" label.

@gwdp
gwdp force-pushed the gwdp/eng-28070-cli-preview-links branch from 9215da3 to 11f8a34 Compare October 15, 2026 02:55
@gwdp
gwdp force-pushed the gwdp/eng-28070-cli-preview-links branch from 11f8a34 to e99db61 Compare October 15, 2026 19:06
@gwdp

gwdp commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

Codex restacked this PR on the rebased build-tools change. CLI executable changes are unchanged; the release note now uses the required changeset format and retains its breaking-change classification.

All 188 focused CLI tests, production typecheck, full lint/format, and changeset validation pass. No review was re-requested.

— Codex

Base automatically changed from gwdp/eng-28070-worker-preview-sharing to main October 15, 2026 21:25
@gwdp
gwdp force-pushed the gwdp/eng-28070-cli-preview-links branch from e99db61 to 0c443ae Compare October 15, 2026 21:25
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding a changeset!

@gwdp
gwdp merged commit 18a008a into main Oct 15, 2026
10 of 11 checks passed
@gwdp
gwdp deleted the gwdp/eng-28070-cli-preview-links branch October 15, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants