Skip to content

[build-tools] Use private links for private simulator sessions - #4620

Merged
gwdp merged 6 commits into
mainfrom
gwdp/eng-28070-worker-preview-sharing
Oct 15, 2026
Merged

gwdp merged 6 commits into
mainfrom
gwdp/eng-28070-worker-preview-sharing

Conversation

@gwdp

@gwdp gwdp commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Why

Use the session's saved private/public choice for worker preview links and the simulator's Share button. Part of ENG-28070.

How

  • Read public_preview for all five iOS session types. Older jobs without the field keep their public behavior.
  • For private sessions, pass --disable-share, omit --share-url, and print the authenticated website link supplied by WWW.
  • For public sessions, keep the public link and native Share button.
  • If a private link is missing, report it as unavailable. Keep preview URLs and tokens in remote config so the website can connect.
  • Redact preview tokens from host startup and recording failure diagnostics.

Release serve-sim #336 first, then this worker change, then WWW #32347. CLI #4619 builds on this PR.

Agent use

Gabe directed the behavior and reviewed the final changes. Codex wrote the code, tests, and description. At Gabe's request, the worker passes flags directly without version probing. Independent source review found no blocker.

Test Plan

Codex ran all 275 tests across the eight affected build-tools suites after rebasing, plus production typecheck and full repository lint/format. Independent source review found no further runtime defects. Release notes use the current changeset format. Hosted validation of the saved preference remains pending.

Earlier local launch validation ran Universe-generated steps through build-tools download, install, and start on a real iOS Simulator. It checked one app start, launch arguments, and the deep link, with a pinned local serve-sim build and loopback adapters for cloud tunnel/reporting calls. CI and hosted EAS testing are separate.

— Codex

@linear-code

linear-code Bot commented Oct 14, 2026

Copy link
Copy Markdown

ENG-28070

@gwdp

gwdp commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author

Codex implemented the build-tools sharing inputs, direct serve-sim flags, and private-link logging under Gabe’s direction, then removed the version probe and its tests at Gabe’s request.

— Codex

@gwdp gwdp self-assigned this Oct 14, 2026
@codecov

This comment has been minimized.

@gwdp

This comment has been minimized.

@gwdp
gwdp added this pull request to stack #4621 October 14, 2026 03:42
@gwdp

This comment has been minimized.

@gwdp gwdp changed the title [build-tools] Respect simulator preview sharing preferences [build-tools] Use private links for private simulator sessions Oct 14, 2026
@gwdp
gwdp marked this pull request as ready for review October 14, 2026 08:15
@gwdp
gwdp requested a review from szdziedzic October 14, 2026 08:15

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment thread packages/build-tools/src/steps/utils/deviceSessionHost.ts
@douglowder

Copy link
Copy Markdown
Contributor

eas-cli now uses changesets for changelogs (#4580). The required "Check for a changeset" check fails on PRs that edit CHANGELOG.md.

To update this PR:

  1. Revert the changes to CHANGELOG.md.
  2. Run yarn changeset, select the changed packages and the bump type, and write the summary.
  3. Commit the new file in .changeset/.

The release adds the PR link and the author to the entry. If this PR needs no changelog entry, revert the CHANGELOG.md changes and add the "no changelog" label.

@gwdp
gwdp force-pushed the gwdp/eng-28070-worker-preview-sharing branch from bf0b216 to 8cfbde1 Compare October 15, 2026 19:06
@gwdp

gwdp commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

Codex rebased this PR onto main 4ec2a5f, preserving the new serve-sim startup flow, worker REST authentication, and ngrok token isolation. Conflict cleanup updates the test token arguments and converts the release note to the required changeset format. No intended sharing behavior changed.

All 275 tests in the eight affected build-tools suites, production typecheck, full lint/format, and changeset validation pass. Independent source review found no remaining runtime regression.

— Codex

@github-actions

Copy link
Copy Markdown

✅ Thank you for adding a changeset!

@gwdp
gwdp merged commit c4064ea into main Oct 15, 2026
10 checks passed
@gwdp
gwdp deleted the gwdp/eng-28070-worker-preview-sharing branch October 15, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants