Repository navigation
[build-tools] Use private links for private simulator sessions - #4620
Conversation
|
Codex implemented the build-tools sharing inputs, direct serve-sim flags, and private-link logging under Gabe’s direction, then removed the version probe and its tests at Gabe’s request. — Codex |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
eas-cli now uses changesets for changelogs (#4580). The required "Check for a changeset" check fails on PRs that edit To update this PR:
The release adds the PR link and the author to the entry. If this PR needs no changelog entry, revert the |
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Edited-by: Codex
bf0b216 to
8cfbde1
Compare
|
Codex rebased this PR onto main 4ec2a5f, preserving the new serve-sim startup flow, worker REST authentication, and ngrok token isolation. Conflict cleanup updates the test token arguments and converts the release note to the required changeset format. No intended sharing behavior changed. All 275 tests in the eight affected build-tools suites, production typecheck, full lint/format, and changeset validation pass. Independent source review found no remaining runtime regression. — Codex |
|
✅ Thank you for adding a changeset! |
Why
Use the session's saved private/public choice for worker preview links and the simulator's Share button. Part of ENG-28070.
How
public_previewfor all five iOS session types. Older jobs without the field keep their public behavior.--disable-share, omit--share-url, and print the authenticated website link supplied by WWW.Release serve-sim #336 first, then this worker change, then WWW #32347. CLI #4619 builds on this PR.
Agent use
Gabe directed the behavior and reviewed the final changes. Codex wrote the code, tests, and description. At Gabe's request, the worker passes flags directly without version probing. Independent source review found no blocker.
Test Plan
Codex ran all 275 tests across the eight affected build-tools suites after rebasing, plus production typecheck and full repository lint/format. Independent source review found no further runtime defects. Release notes use the current changeset format. Hosted validation of the saved preference remains pending.
Earlier local launch validation ran Universe-generated steps through build-tools download, install, and start on a real iOS Simulator. It checked one app start, launch arguments, and the deep link, with a pinned local serve-sim build and loopback adapters for cloud tunnel/reporting calls. CI and hosted EAS testing are separate.
— Codex