fix(mobile-api): today + available book → immediate loan, not reservation

[fabiodalez-dev]

P1/P2 from the mobile review. The Android app's Request loan on an available title sends today's date (its date picker pre-selects the first free day = today). The backend (ActionsController) only treated a request as an immediate loan when desired_date was absent — so the available-now flow silently created a reservation instead of a pending loan / admin-approval request.

Fix: treat desired_date empty or == today + a free copy as an immediate loan; a future date stays a reservation. This corrects the behaviour for the already-deployed APK with no app change.

New reusable E2E (mobile-api-behaviors #26) asserts today+available → type=loan. Validated: 27/27 mobile-api-behaviors, PHPStan L5.

[coderabbitai]

Warning

Review limit reached

@fabiodalez-dev, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 15 minutes and 1 second. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 753321d6-c72d-41dc-a2ed-e99dbda88144

📥 Commits

Reviewing files that changed from the base of the PR and between 1a752ec and ba10292.

📒 Files selected for processing (2)

• storage/plugins/mobile-api/src/Controllers/ActionsController.php
• tests/mobile-api-behaviors.spec.js

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/mobile-loan-today-immediate

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[fabiodalez-dev]

Superseded by #194 (consolidated mobile-API contract coherence). Changes included there.