Skip to content

feat(mobile-api): Android contract coherence (plugin settings, loan, availability, OpenAPI)#194

Merged
fabiodalez-dev merged 2 commits into
mainfrom
feat/mobile-api-android-coherence
Jun 25, 2026
Merged

feat(mobile-api): Android contract coherence (plugin settings, loan, availability, OpenAPI)#194
fabiodalez-dev merged 2 commits into
mainfrom
feat/mobile-api-android-coherence

Conversation

@fabiodalez-dev

Copy link
Copy Markdown
Owner

Consolidated mobile-API ⇄ Android contract work. Supersedes #191 and #193 (their changes are included here) and adds:

Backend

  • Plugin settings reachable + saveable — generic Impostazioni button for any plugin with a settings page; POST delegates self-rendering pages to settingsPage() so the Mobile API access toggle persists.
  • Loan vs reservationdesired_date empty or today on an available book is an immediate loan, not a reservation.
  • Availability calendar contractCatalogController::normalizeMobileAvailabilityDays maps website labels to the app's free|partial|full states.
  • OpenAPI coherence — the generated spec aligned with the live endpoints.
  • E2E: mobile-api-behaviors + idempotency updated.

Verification: PHPStan L5 clean · 57 mobile-api E2E pass.

The matching Android changes (register/forgot UI, feature-flag gating, contract alignment) are in the Android repo's companion PR.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@fabiodalez-dev, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 40 minutes and 20 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: f2a29932-2d66-4ab7-85dd-ea5dae9893ed

📥 Commits

Reviewing files that changed from the base of the PR and between 1a752ec and da0508d.

📒 Files selected for processing (7)
  • app/Controllers/PluginController.php
  • app/Views/admin/plugins.php
  • storage/plugins/mobile-api/src/Controllers/ActionsController.php
  • storage/plugins/mobile-api/src/Controllers/CatalogController.php
  • storage/plugins/mobile-api/src/Controllers/OpenApiController.php
  • tests/mobile-api-behaviors.spec.js
  • tests/mobile-api-idempotency.spec.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/mobile-api-android-coherence

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…he real /messages contract

messageRequestSchema declared required:[subject, body] with only subject/body,
but ActionsController::sendMessage never reads `subject` and takes the message
text from `messaggio` (aliases `message`/`body`), with nome/cognome/email
defaulting to the authenticated user and optional telefono/indirizzo. Document
the real contract so clients (the Android app) follow an accurate spec.
Runtime was already working via the `body` alias; this fixes the spec accuracy
flagged by the contract-coherence review.

Verified: PHPStan L5, live /api/v1/openapi.json now reflects the real fields.
@fabiodalez-dev fabiodalez-dev merged commit 6e75d41 into main Jun 25, 2026
6 checks passed
@fabiodalez-dev fabiodalez-dev deleted the feat/mobile-api-android-coherence branch June 25, 2026 06:39
fabiodalez-dev added a commit that referenced this pull request Jun 25, 2026
…192)

- Bump version.json to 0.7.23
- Mobile API plugin 1.0.0 -> 1.0.1 (reachable settings, loan-vs-reservation
  parity, availability free/partial/full, OpenAPI contract realigned)
- README: add "What's New in v0.7.23" section
- Code-only release, no new migration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant