Skip to content

fix(config): resolve device pixel ratio through env#11040

Merged
asturur merged 4 commits into
masterfrom
divide-packages-more-step3
Jul 8, 2026
Merged

fix(config): resolve device pixel ratio through env#11040
asturur merged 4 commits into
masterfrom
divide-packages-more-step3

Conversation

@asturur

@asturur asturur commented Jul 7, 2026

Copy link
Copy Markdown
Member

Resolve device pixel ratio through the environment boundary instead of reading browser globals from core configuration defaults.

  • Leave config.devicePixelRatio unset by default so it acts as an explicit override.
  • Resolve DPR at usage time with the compact config/env-window/1 fallback expression.
  • Cover configured, browser-env, and fallback DPR behavior in env tests.
  • Ignore generated top-level e2e report output for git and prettier checks.

related to #10894

@codesandbox

codesandbox Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Build Stats

file / KB (diff) bundled minified
fabric 774.151 (+0.001) 293.655 (-0.021)

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

=============================== Coverage summary ===============================
Statements   : 79.81% ( 8035/10067 )
Branches     : 76.74% ( 4323/5633 )
Functions    : 85.48% ( 1525/1784 )
Lines        : 79.8% ( 7855/9843 )
================================================================================

@asturur

asturur commented Jul 7, 2026

Copy link
Copy Markdown
Member Author

ok next PR should be the large one. Where i move all src files

@sonarqubecloud

sonarqubecloud Bot commented Jul 7, 2026

Copy link
Copy Markdown

Comment thread .gitignore
/cli_output/
/packages/e2e/test-report/
/packages/e2e/test-results/
/e2e/

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you ignoring the whole e2e package?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the package has moved in packages/e2e but i still had the folder full of test-report and test-results, as soon as .gitignore was modified my git wanted to track those files again and again, so i cut it out. everything is in packages/e2e in theory

@asturur
asturur merged commit 723838f into master Jul 8, 2026
18 checks passed
@asturur
asturur deleted the divide-packages-more-step3 branch July 8, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants