[RFC] Fix reviewstack.dev deploy by removing broken Docker container dependency

[ajaymenon]

Summary

The repo used to have a CI workflow that built an Ubuntu 22.04 Docker image (generated by ci/gen_workflows.py as sapling-cli-ubuntu-22.04-image.yml) and pushed it to GitHub Container Registry as ghcr.io/facebook/sapling/build_ubuntu_22_04:latest. At some point, that workflow and its Dockerfile were removed from the repo, but two workflows that depend on that image were never updated:

• reviewstack.dev-deploy.yml
• sapling-addons.yml

So every time either of those workflows runs, it tries to pull an image that no longer exists, and fails immediately at container initialization.

Example failure on main: https://github.com/facebook/sapling/actions/runs/21693937235/job/62559938248

Test Plan

Not 100% sure how to test this tbh. I tried to add a trigger to get GHA to pick up the change and see if the deploy action would succeed but it looks like I don't have permissions to do that.

ubuntu-22.04 should already have node and yarn so the build deployment should work without any custom dependencies.

[facebook-github-bot]

@ajaymenon has updated the pull request. You must reimport the pull request before landing.

[meta-codesync]

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D92435020. (Because this pull request was imported automatically, there will not be any future comments.)

[bherila]

Could I request you restore the comments and remove trailing whitespace, I will check tomorrow to see how we can validate the diff. I think it is OK however, just these nits :)

[bherila]

Btw thank you for your contribution to reviewstack!

[facebook-github-bot]

@ajaymenon has updated the pull request. You must reimport the pull request before landing.

[ajaymenon]

Also still getting used to Github as opposed to Phabricator - I've made the requested changes and was able to re-request review, but it still says the PR has changes requested.

[bherila]

Thanks, I will get to it today anyway!

[ajaymenon]

@bherila - it seems that Merging is blocked because "Merge is not an allowed merge method in this repository". Not quite sure how else I'm supposed to commit this PR. Would you be willing to take it over?

The reason the local build+deploy method doesn't solve my problem is because my colleagues are the ones trying to use reviewstack to review my PRs internally.

[bherila]

Because I made a change to this diff internally, I need an additional review from another employee. If any Meta employee sees this and can merge the diff, please do! I will ping some more people today if not.

[bherila]

By the way @ajaymenon

1. if you make a new PR for this there is a good chance I can merge it without my changes, then I can rebase this one (sorry, even if I undo my changes on this one I will still need another employee's review)
2. check out [reviewstack] idea: sticky header while scrolling in side-by-side diff review #1213 , [reviewstack] when copying code to clipboard in side by side diff view, ensure the line numbers aren't copied. #1214 which might be waiting for anyway :)

but I'm asking around! (fyi, Reviewstack is a "extracurricular" project, It's not my primary job.)

[ajaymenon]

I would love to make a new PR right now but the github outages are making that impossible on my side. Also no pressure I get it's a side thing - appreciate your followups here!

@ashwinb maybe you could help approve this PR from the other side?

[ajaymenon]

Nvm was able to make #1216