Skip to content

Conversation

@ajaymenon
Copy link

@ajaymenon ajaymenon commented Feb 9, 2026

Summary

The repo used to have a CI workflow that built an Ubuntu 22.04 Docker image (generated by ci/gen_workflows.py as sapling-cli-ubuntu-22.04-image.yml) and pushed it to GitHub Container Registry as ghcr.io/facebook/sapling/build_ubuntu_22_04:latest. At some point, that workflow and its Dockerfile were removed from the repo, but two workflows that depend on that image were never updated:

  • reviewstack.dev-deploy.yml
  • sapling-addons.yml

So every time either of those workflows runs, it tries to pull an image that no longer exists, and fails immediately at container initialization.

Example failure on main: https://github.com/facebook/sapling/actions/runs/21693937235/job/62559938248

Test Plan

Not 100% sure how to test this tbh. I tried to add a trigger to get GHA to pick up the change and see if the deploy action would succeed but it looks like I don't have permissions to do that.

ubuntu-22.04 should already have node and yarn so the build deployment should work without any custom dependencies.

Redo of #1208

@meta-codesync
Copy link

meta-codesync bot commented Feb 9, 2026

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D92742046. (Because this pull request was imported automatically, there will not be any future comments.)

@bherila
Copy link
Contributor

bherila commented Feb 9, 2026

Thanks, running the CI now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants