[RFC] Fix reviewstack.dev deploy by removing broken Docker container dependency take 2 #1216
+7
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The repo used to have a CI workflow that built an Ubuntu 22.04 Docker image (generated by
ci/gen_workflows.pyassapling-cli-ubuntu-22.04-image.yml) and pushed it to GitHub Container Registry asghcr.io/facebook/sapling/build_ubuntu_22_04:latest. At some point, that workflow and its Dockerfile were removed from the repo, but two workflows that depend on that image were never updated:reviewstack.dev-deploy.ymlsapling-addons.ymlSo every time either of those workflows runs, it tries to pull an image that no longer exists, and fails immediately at container initialization.
Example failure on
main: https://github.com/facebook/sapling/actions/runs/21693937235/job/62559938248Test Plan
Not 100% sure how to test this tbh. I tried to add a trigger to get GHA to pick up the change and see if the deploy action would succeed but it looks like I don't have permissions to do that.
ubuntu-22.04 should already have node and yarn so the build deployment should work without any custom dependencies.
Redo of #1208