--[BE] Fix issues with bindings exposed by pybind11-stubgen - #2430
Merged
Conversation
raw setters and initializers should not be used for attributes, since they may corrupt a required field.
facebook-github-bot
added
the
CLA Signed
mosra
reviewed
Jul 18, 2024
| [](Configuration& self, const std::string& key, const T val) { | ||
| self.set(key, val); | ||
| }, | ||
| ("Set the value specified by given string key to be specified " + |
Contributor
There was a problem hiding this comment.
I'm not sure if this actually works, as far as I remember the reason def() accepted a plain const char* was because it just referenced it without actually copying anywhere. So when retrieving documentation of those, you'll get a crash due to a dangling pointer.
I might be wrong, but I personally hope it's not doing a string copy for every docstring. That'd be nasty.
Contributor
Author
There was a problem hiding this comment.
@mosra The __init__.pyi has an appropriate doc string listed :
@typing.overload
def set(self, key: str, value: str) -> None:
"""
Set the value specified by given string key to be specified string value
"""
Would the problem be somewhere else?
__init__.pyi also has duplicate entries for the const char* and const str& versions. I going to get rid of the const char* specializations.
Contributor
There was a problem hiding this comment.
Oh, alright, then it works. I wasn't sure.
jturner65
force-pushed
the
Bindings_AddMissingBindings
branch
from
July 18, 2024 20:01
5cc0927 to
0423a45
Compare
jturner65
force-pushed
the
Bindings_AddMissingBindings
branch
from
July 19, 2024 15:21
0423a45 to
a86c933
Compare
Contributor
Author
|
Current Main's stubgen errors : The PR in its current state's errors : |
jturner65
changed the title
0mdc
approved these changes
Jul 19, 2024
0mdc
left a comment
0mdc
left a comment
Contributor
There was a problem hiding this comment.
Did another pass on the latest changes. LGTM! Thanks for doing this.
| .value("LINK_VISUALS", | ||
| metadata::attributes::ArticulatedObjectRenderMode::LinkVisuals, | ||
| "Render the Articulated Object using urdf-defined " | ||
| "meshes/primitives to respresent each link.") |
| R"(Whether or not the asset described by this attributes supports texture-based semantics)") | ||
| .def_property_readonly( | ||
| "num_regions", &SemanticAttributes::getNumRegionInstances, | ||
| R"(The nmumber of semantic regions defined by this Semantic Attributes.)"); |
|
|
||
| /** | ||
| * @brief Deque holding all released IDs to consume for light instances when | ||
| * @brief Deque holding all released IDs to consume for @ref LightInstanceAttributess when |
Contributor
There was a problem hiding this comment.
Nit: LightInstanceAttributess
| [semanticAttribs](bool has_semantic_textures) { | ||
| semanticAttribs->setHasSemanticTextures(has_semantic_textures); | ||
| }); | ||
|
|
| // "'s articulated link specified by the passed " | ||
| // "link_id. Use link_id==-1 to get the base link.") | ||
| // .c_str(), | ||
| // "link_id"_a) |
Contributor
Author
There was a problem hiding this comment.
Yes, @aclegg3 and I have been discussing a mechanism for this.
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR adds missing bindings and fixes broken ones as exposed by pybind11-stubgen which is being introduced in this PR
How Has This Been Tested
All local c++ and python tests pass
Types of changes
Checklist