Fixed FancyShowCaseView not hiding for CUSTOM VIEW#169
Open
Rajnish23 wants to merge 2 commits into
Open
Conversation
Owner
|
The root cause of this problem should be solved from the library not the sample. FancyImageView is added multiple times. It should be fixed. |
Contributor
Author
I have made changes in library. Please review it. |
AdrianLxM
reviewed
Dec 20, 2019
| fun build(): FancyShowCaseView { | ||
| if(isVisible(activity)){ | ||
| hideCurrent(activity) | ||
| } |
Contributor
There was a problem hiding this comment.
Hi, I like the idea of auto-hiding, yet shouldn't this be done in the show() function. The build() function would also be used to prepare show cases to be enqueued e.g..
Contributor
Author
There was a problem hiding this comment.
Yeah, I do agree this should be done inside show() function instead of the build method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #161