Skip to content

Fixed FancyShowCaseView not hiding for CUSTOM VIEW #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rajnish23 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed FancyShowCaseView not hiding for CUSTOM VIEW #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecb83e9
Fixed FancyShowCaseView not hiding for CUSTOM VIEW
Rajnish23 Oct 29, 2019
081937a
Fixed FancyImageView added multiple times
Rajnish23 Nov 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions app/src/main/java/me/toptas/fancyshowcasesample/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import android.graphics.Color
import android.os.Bundle
import android.text.Html
import android.text.Spanned
import android.util.Log
import android.util.TypedValue
import android.view.Gravity
import android.view.Menu
Expand Down Expand Up @@ -124,25 +125,21 @@ class MainActivity : BaseActivity() {

//Shows a FancyShowCaseView that focus on a view
btn_focus_dismiss_on_focus_area.setOnClickListener {
if (FancyShowCaseView.isVisible(this)) {
Toast.makeText(this, "Clickable button", Toast.LENGTH_SHORT).show()
FancyShowCaseView.hideCurrent(this)
} else {
FancyShowCaseView.Builder(this)
Toast.makeText(this, "Clickable button", Toast.LENGTH_SHORT).show()

FancyShowCaseView.Builder(this)
.focusOn(findViewById(R.id.btn_focus_dismiss_on_focus_area))
.enableTouchOnFocusedView(true)
.title("Focus on View \n(dismiss on focus area)")
.build()
.show()
}

}

//Shows a FancyShowCaseView with rounded rect focus shape
btn_rounded_rect_dismiss_on_focus_area.setOnClickListener {
if (FancyShowCaseView.isVisible(this)) {
Toast.makeText(this, "Clickable button", Toast.LENGTH_SHORT).show()
FancyShowCaseView.hideCurrent(this)
} else {
Toast.makeText(this, "Clickable button", Toast.LENGTH_SHORT).show()

FancyShowCaseView.Builder(this)
.focusOn(it)
.focusShape(FocusShape.ROUNDED_RECTANGLE)
Expand All @@ -151,7 +148,7 @@ class MainActivity : BaseActivity() {
.title("Focus on View \n(dismiss on focus area)")
.build()
.show()
}

}

//Shows FancyShowCaseView with focusCircleRadiusFactor 1.5 and title gravity
Expand Down Expand Up @@ -271,6 +268,7 @@ class MainActivity : BaseActivity() {
})
.closeOnTouch(false)
.build()

mFancyShowCaseView?.show()

}
Expand Down
3 changes: 3 additions & 0 deletions fancyshowcaseview/src/main/java/me/toptas/fancyshowcase/FancyShowCaseView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,6 +902,9 @@ class FancyShowCaseView @JvmOverloads constructor(context: Context, attrs: Attri
* @return [FancyShowCaseView] with given parameters
*/
fun build(): FancyShowCaseView {
if(isVisible(activity)){
hideCurrent(activity)
}
Copy link
Copy Markdown
Contributor

@AdrianLxM AdrianLxM Dec 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I like the idea of auto-hiding, yet shouldn't this be done in the show() function. The build() function would also be used to prepare show cases to be enqueued e.g..

Copy link
Copy Markdown
Contributor Author

@Rajnish23 Rajnish23 Dec 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I do agree this should be done inside show() function instead of the build method.

return FancyShowCaseView(activity, focusedView, clickableView, mId, mTitle, mSpannedTitle, mTitleGravity, mTitleStyle, mTitleSize, mTitleSizeUnit,
focusCircleRadiusFactor, mBackgroundColor, mFocusBorderColor, mFocusBorderSize, mCustomViewRes, viewInflateListener,
mEnterAnimation, mExitAnimation, mAnimationListener, mCloseOnTouch, mEnableTouchOnFocusedView, fitSystemWindows, mFocusShape, mDismissListener, mRoundRectRadius,
Expand Down