Add scalar geometry option - #53
Merged
Merged
Conversation
schnellerhase
left a comment
schnellerhase
left a comment
Collaborator
There was a problem hiding this comment.
Needs a unit test.
schnellerhase
approved these changes
Aug 25, 2026
schnellerhase
left a comment
schnellerhase
left a comment
Collaborator
There was a problem hiding this comment.
Can we create an issue to track reverting this once we have proper support for other geometry types?
Co-authored-by: Paul T. Kühner <56360279+schnellerhase@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
form_compiler_options={"scalar_geometry": True}this forces the C++ backend to generated the code that uses the same template typeTto be used for the assembled tensor and also for all geometry quantities.Much better fix would be to properly support different types in FFCx, that is for a larger rewrite.