Repository navigation
fix(marketplace): fall back to commentsPermalink and document DELETE quirks in the skill - #73
Merged
Merged
Conversation
…quirks in the skill Tested the skill against the live API with a real bookmark pile: - 88 of 274 bookmarks (shares, freeform posts, collections) have an empty url; commentsPermalink is always set, so use it as the link - DELETE with Content-Type: application/json and no body returns 400 - DELETE is idempotent (a second delete returns 204, not 404) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 19 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ran the Bookmarks Roulette skill against the live Public API (274 real bookmarks, plus a throwaway bait bookmark for the trigger) and fixed what it surfaced:
url: 88 of 274 bookmarks (32%:share,freeformandcollectionposts) come withurl: "". The poster and the "spare it" suggestion now fall back tocommentsPermalink, which was set on all 274.DELETE+Content-Type: sendingContent-Type: application/jsonon a bodylessDELETEreturns400 Body cannot be empty. The skill now says to omit it.204, not404. The 404 note is reworded accordingly.Confirmed as written: 401 on a missing or invalid token, cursor pagination (
hasNextPage/cursor),204on delete with the bookmark gone from the list.The web app has the same empty-
urlbug when sparing; that fix is in a separate PR.Test plan
pnpm format:check🤖 Generated with Claude Code