Fix release-profile duplicate sources jar after finos parent bump to 10 - #738
Merged
hugohills-regnosys merged 1 commit intoSep 15, 2026
Conversation
finos:finos 10 renamed its release profile's maven-source-plugin execution from "attach-sources" to "release-attach-sources". Our override in the release profile (added to avoid the duplicate sources jar this parent execution produces alongside our own "default" execution) still targeted the old id, so after the bump the parent's execution ran unblocked and duplicated `default`'s sources jar: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-source-plugin:3.3.1:jar (default) on project serialization: Presumably you have configured maven-source-plugin to execute twice in your build. You have to configure a classifier for at least one of them. Verified locally with: mvn -P release -Dgpg.skip=true -pl common -am package
hugohills-regnosys
merged commit Sep 15, 2026
f4a6456
into
finos:dependabot/maven/org.finos-finos-10
6 checks passed
hugohills-regnosys
added a commit
that referenced
this pull request
Sep 15, 2026
* Bump org.finos:finos from 7 to 10 Bumps [org.finos:finos](https://github.com/finos/finos-parent-pom) from 7 to 10. - [Release notes](https://github.com/finos/finos-parent-pom/releases) - [Commits](https://github.com/finos/finos-parent-pom/commits) --- updated-dependencies: - dependency-name: org.finos:finos dependency-version: '10' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Match the finos parent's renamed release-sources execution id (#738) finos:finos 10 renamed its release profile's maven-source-plugin execution from "attach-sources" to "release-attach-sources". Our override in the release profile (added to avoid the duplicate sources jar this parent execution produces alongside our own "default" execution) still targeted the old id, so after the bump the parent's execution ran unblocked and duplicated `default`'s sources jar: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-source-plugin:3.3.1:jar (default) on project serialization: Presumably you have configured maven-source-plugin to execute twice in your build. You have to configure a classifier for at least one of them. Verified locally with: mvn -P release -Dgpg.skip=true -pl common -am package --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hugo Hills <39260692+hugohills-regnosys@users.noreply.github.com>
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
org.finos:finosfrom 7 to 10) fails theFINOS/rune-commonCodefresh build, which runsmvn clean install ... -P release.finos:finos10 renamed itsreleaseprofile'smaven-source-pluginexecution fromattach-sourcestorelease-attach-sources. Our ownreleaseprofile inpom.xmldisables that parent execution by overriding it by id (to avoid duplicating our owndefault/jarsources-attach execution) — after the bump, the id no longer matches, so the parent's execution ran unblocked alongside ours and both tried to attach asources-classified artifact:release-attach-sourcesto match the parent's new id.This targets #732's own branch (
dependabot/maven/org.finos-finos-10), notmain— the fix only makes sense combined with the version-10 bump; merged standalone against the current parent (v7) it would reintroduce the same duplicate-artifact failure in reverse.Test plan
mvn -P release -Dgpg.skip=true -pl common -am package— reproduced the failure before the fix, passed after.