Repository navigation
fix: hide receipts for catalogue list lookups - #252
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Confidence score: 4/5
- In
src/commands/list.ts, rootlistcategory lookups bypassfetchPage, so they still print aRequest IDdespite receipt suppression elsewhere; apply the same suppression torequestCategoriesfor consistent output.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/commands/list.ts">
<violation number="1" location="src/commands/list.ts:333">
P2: The receipt suppression only covers Find Tools page lookups; root `list` category lookups still print `Request ID` because they bypass `fetchPage`. Apply the same receipt suppression to `requestCategories` so all catalogue `list` lookups have receipt-free stderr.</violation>
</file>
Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.
Shadow auto-approve: would not auto-approve because issues were found.
Fix all with cubic | Re-trigger cubic
| }, | ||
| ], | ||
| options | ||
| { ...options, showReceipt: false } |
Contributor
There was a problem hiding this comment.
P2: The receipt suppression only covers Find Tools page lookups; root list category lookups still print Request ID because they bypass fetchPage. Apply the same receipt suppression to requestCategories so all catalogue list lookups have receipt-free stderr.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/commands/list.ts, line 333:
<comment>The receipt suppression only covers Find Tools page lookups; root `list` category lookups still print `Request ID` because they bypass `fetchPage`. Apply the same receipt suppression to `requestCategories` so all catalogue `list` lookups have receipt-free stderr.</comment>
<file context>
@@ -330,7 +330,7 @@ export async function handleList(
},
],
- options
+ { ...options, showReceipt: false }
);
receipts.push({
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catalogue
listlookups now omit the Request ID, Scrape ID, and Credits lines from stderr. Structured JSON retains receipt metadata, and execution commands and error messages retain their existing behavior.Validation: TypeScript build and the list/Alexandria test suites passed. Updated the existing pagination test to verify receipt lines are absent.
Summary by cubic
Catalogue
listlookups no longer print Request ID, Scrape ID, and Credits lines to stderr. Structured JSON output still includes receipt metadata, and other commands keep printing receipts as before.Written for commit bae2812. Summary will update on new commits.